Skip to content
This repository was archived by the owner on Nov 11, 2022. It is now read-only.

Conversation

@tgroh
Copy link
Contributor

@tgroh tgroh commented Aug 12, 2016

This PTransform Reifies and gathers all panes produced for each
window, outputting a single pane per window at the time the window is
Garbage Collected.

For use in DataflowAssert, to match over the final contents of each
window.

backports apache/beam#180
backports minor additional changes to GatherAllPanes in Beam HEAD

@tgroh
Copy link
Contributor Author

tgroh commented Aug 12, 2016

R: @bjchambers

This PTransform Reifies and gathers all panes produced for each
window, outputting a single pane per window at the time the window is
Garbage Collected.

For use in DataflowAssert, to match over the final contents of each
window.
/**
* Gathers all panes of each window into exactly one output.
*
* <p>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<p> Note ...

no newline after <p>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@bjchambers
Copy link
Contributor

LGTM

@bjchambers bjchambers merged commit a4afc9e into GoogleCloudPlatform:master Aug 17, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants