-
Notifications
You must be signed in to change notification settings - Fork 4.5k
[BEAM-155] Add GatherAllPanes PTransform #180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PTransform Reifies and gathers all panes produced for each window, outputting a single pane per window at the time the window is Garbage Collected. For use in PAssert, to match over the final contents of each window.
5d4ae9e to
3cda11a
Compare
| import org.apache.beam.sdk.values.TypeDescriptor; | ||
|
|
||
| /** | ||
| * Accumulates all panes that are output to the input {@link PCollection}, reifying the contents of |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/**
* Gathers all panes of each window into exactly one output.
* <p>
* Note that this will delay the output of a window until the garbage collection
* time (when the watermark passes the end of the window plus allowed lateness) even if the up-stream triggers closed the window earlier.
*/
Member
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Contributor
|
LGTM |
swegner
pushed a commit
to swegner/beam
that referenced
this pull request
Apr 22, 2016
iemejia
pushed a commit
to iemejia/beam
that referenced
this pull request
Jan 12, 2018
mareksimunek
pushed a commit
to mareksimunek/beam
that referenced
this pull request
May 9, 2018
…y-flow 157 enable outputs to modify flow
damccorm
pushed a commit
that referenced
this pull request
Dec 19, 2022
lostluck
pushed a commit
to lostluck/beam
that referenced
this pull request
Dec 22, 2022
Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local> Co-authored-by: Elias Segundo Antonio <eliassegundo.segundo@gmail.com> Co-authored-by: Elias Segundo <elias.segundo@luisrazo.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
[BEAM-<Jira issue #>] Description of pull requestmvn clean verify. (Even better, enableTravis-CI on your fork and ensure the whole test matrix passes).
<Jira issue #>in the title with the actual Jira issuenumber, if there is one.
Individual Contributor License Agreement.
This PTransform Reifies and gathers all panes produced for each
window, outputting a single pane per window at the time the window is
Garbage Collected.
For use in PAssert, to match over the final contents of each window.