Skip to content

make adjustments to quickstart#28

Merged
alphanota merged 1 commit into
GoogleCloudPlatform:mainfrom
alphanota:quickstart-updates
Jan 11, 2024
Merged

make adjustments to quickstart#28
alphanota merged 1 commit into
GoogleCloudPlatform:mainfrom
alphanota:quickstart-updates

Conversation

@alphanota
Copy link
Copy Markdown
Collaborator

@alphanota alphanota commented Jan 9, 2024

  1. Move custom target and AR repo creation to prerequisites section.
  2. Make a temporary copy of clouddeploy.yaml and skaffold.yaml rather than overwriting original.

@alphanota alphanota self-assigned this Jan 9, 2024
mattsanta
mattsanta approved these changes Jan 9, 2024
View reviewed changes
Copy link
Copy Markdown
Collaborator

@mattsanta mattsanta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - i trust you'll go through the quickstart and make sure everything works.

@alphanota alphanota merged commit 11731ca into GoogleCloudPlatform:main Jan 11, 2024
alphanota added a commit to alphanota/cloud-deploy-samples that referenced this pull request Jan 11, 2024
@alphanota
make adjustments to quickstart (GoogleCloudPlatform#28)
e6097e5
edwardthiele pushed a commit that referenced this pull request Apr 3, 2024
@alphanota @edwardthiele
make adjustments to quickstart (#28)
d67dadb
edwardthiele pushed a commit that referenced this pull request Apr 4, 2024
@alphanota @edwardthiele
make adjustments to quickstart (#28)
f856ae3
edwardthiele added a commit that referenced this pull request Apr 5, 2024
@edwardthiele @mattsanta
@plumpy @alphanota @nateaveryg @dorbin @palladius
Support using env vars when configuring verify-evaluate-cloud-metrics (…
89facd5 
…#40)

* Allow users to use env-vars for some values

* Create presubmit.yaml (#17)

* Add sample implementation of a GitOps custom target (#14)

* Introduce sample Terraform custom target implementation and quickstart

* Fix terraform deployer module name, params comment, and build and register script perm

* Add disclaimer in terraform readme indicating that the sample is not an officially supported Google product

* Remove cloudbuild.yaml and build and register script temporarily

* Update terraform sample with changes required to include the images commit sha in metadata

* Fix module dependency version in terraform deployer

* Fix the COMMIT_SHA.

(And simplify it a little.)

* Update the appearance of the build_and_register output

The primary log lines are now green and start with ">> ".

* Add clone repo instructions to terraform quickstart and readme in the custom target directory

* Doc updates for Terraform sample and using const for sample commit sha metadata key

* Add gitops custom target sample

* Git Deployer sample: set username and email in git config after cloning the repo

* Git deployer: set <> as the email in the git config if not provided

* GitOps sample: Update README and QUICKSTART and added customTarget/gitEnablePullRequestMerge deploy parameter

* Add docker build for each sample in presubmit.yaml

---------

Co-authored-by: Michael Plump <plumpy@google.com>

* Add vertex ai deployer (#15)

* make some fixes to use new clouddeploy module

* use new clouddeploy gcs methods to download manifest configuration

* fix clouddeploy.yaml to use template

* addalias fixes

* fix gcs download paths

* Supported deploy parameters are stored using customTarget/ prefix

* fix configPath description

* fix README,quickstart, add copyright to clouddeploy.yaml

* Add copyright to more config files

* address comments in request.go

* address most deploy comments

* address render, deploy comments. Split vertex-ai methods to its own file to make render/deploy files easier to read. Moving polling functions to its own functions as well

* Add copy repo step as first step

* typos and grammar

* typo fixe in quickstart

* expands comments for render.go

* add comments on vertex ai

* Create presubmit.yaml (#17)

* Add sample implementation of a GitOps custom target (#14)

* Introduce sample Terraform custom target implementation and quickstart

* Fix terraform deployer module name, params comment, and build and register script perm

* Add disclaimer in terraform readme indicating that the sample is not an officially supported Google product

* Remove cloudbuild.yaml and build and register script temporarily

* Update terraform sample with changes required to include the images commit sha in metadata

* Fix module dependency version in terraform deployer

* Fix the COMMIT_SHA.

(And simplify it a little.)

* Update the appearance of the build_and_register output

The primary log lines are now green and start with ">> ".

* Add clone repo instructions to terraform quickstart and readme in the custom target directory

* Doc updates for Terraform sample and using const for sample commit sha metadata key

* Add gitops custom target sample

* Git Deployer sample: set username and email in git config after cloning the repo

* Git deployer: set <> as the email in the git config if not provided

* GitOps sample: Update README and QUICKSTART and added customTarget/gitEnablePullRequestMerge deploy parameter

* Add docker build for each sample in presubmit.yaml

---------

Co-authored-by: Michael Plump <plumpy@google.com>

* build the model deployer in the presubmit

* make changes to quickstart and readme to include information about add-alias feature in cloud deploy hook

* fix replace variables script

* more fixes

* include add alias feature in vertex ai quick start

* removing spacing between err declaration and handling

* address comments

* configPath points to file rather than directory

* address comments

---------

Co-authored-by: edwardthiele <4979401+edwardthiele@users.noreply.github.com>
Co-authored-by: Matt Santa <mattsanta@google.com>
Co-authored-by: Michael Plump <plumpy@google.com>

* Add sample implementation of an Infrastructure Manager custom target (#18)

* Introduce sample Terraform custom target implementation and quickstart

* Fix terraform deployer module name, params comment, and build and register script perm

* Add disclaimer in terraform readme indicating that the sample is not an officially supported Google product

* Remove cloudbuild.yaml and build and register script temporarily

* Update terraform sample with changes required to include the images commit sha in metadata

* Fix module dependency version in terraform deployer

* Fix the COMMIT_SHA.

(And simplify it a little.)

* Update the appearance of the build_and_register output

The primary log lines are now green and start with ">> ".

* Add clone repo instructions to terraform quickstart and readme in the custom target directory

* Doc updates for Terraform sample and using const for sample commit sha metadata key

* Introduce sample Infrastructure Manager custom target implementation and quickstart

* Pass project ID when describing image in shared custom target build and register script

* Add infrastructure manager sample to presubmit.yaml

* Infrastructure Manager sample: Add Cloud Deploy UI URLs to quickstart

* Update readme and quickstart for infrastruture manager sample

---------

Co-authored-by: Michael Plump <plumpy@google.com>

* Fix the shebang line (#20)

The shebang line needs to be the in the first line of the file (above copyright).

* Update QUICKSTART.md to fix typo (#19)

* make adjustments to quickstart (#28)

* Update README.md (#32)

updated command to create first release.  The command had an underscore between delivery and pipeline instead of a dash.  Also, added a second - in front of the word "delivery"

* Update README.md (#4)

Corrects misleading word in readme for basic-deploy sample

* Update README.md (#30)

forgot a space

* Allow users to use env-vars for some values

* fix bad merge

* fix newline

---------

Co-authored-by: Edward Thiele <edwardth@google.com>
Co-authored-by: Matt Santa <mattsanta@google.com>
Co-authored-by: Michael Plump <plumpy@google.com>
Co-authored-by: Angel Montero <angelmontero@google.com>
Co-authored-by: nateaveryg <103460947+nateaveryg@users.noreply.github.com>
Co-authored-by: Dave Dorbin <ddorbin@google.com>
Co-authored-by: Riccardo Carlesso <palladiusbonton@gmail.com>
edwardthiele added a commit that referenced this pull request Apr 16, 2024
@dependabot @alphanota
@nateaveryg @dorbin @palladius @edwardthiele
Bump golang.org/x/crypto from 0.9.0 to 0.17.0 in /verify-evaluate-clo…
87bc8d0 
…ud-metrics (#27)

* Bump golang.org/x/crypto in /verify-evaluate-cloud-metrics

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.9.0 to 0.17.0.
- [Commits](golang/crypto@v0.9.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

* make adjustments to quickstart (#28)

* Update README.md (#32)

updated command to create first release.  The command had an underscore between delivery and pipeline instead of a dash.  Also, added a second - in front of the word "delivery"

* Update README.md (#4)

Corrects misleading word in readme for basic-deploy sample

* Update README.md (#30)

forgot a space

* Bump golang.org/x/net in /verify-evaluate-cloud-metrics (#2)

Bumps [golang.org/x/net](https://github.com/golang/net) from 0.10.0 to 0.17.0.
- [Commits](golang/net@v0.10.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump google.golang.org/grpc in /verify-evaluate-cloud-metrics (#3)

Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.55.0 to 1.56.3.
- [Release notes](https://github.com/grpc/grpc-go/releases)
- [Commits](grpc/grpc-go@v1.55.0...v1.56.3)

---
updated-dependencies:
- dependency-name: google.golang.org/grpc
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: edwardthiele <4979401+edwardthiele@users.noreply.github.com>

* Bump golang.org/x/crypto from 0.14.0 to 0.17.0 in /custom-targets/util (#21)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](golang/crypto@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/crypto in /custom-targets/vertex-ai/model-deployer (#22)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0.
- [Commits](golang/crypto@v0.14.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/crypto (#23)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.15.0 to 0.17.0.
- [Commits](golang/crypto@v0.15.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/crypto in /custom-targets/git-ops/git-deployer (#24)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0.
- [Commits](golang/crypto@v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump golang.org/x/crypto in /custom-targets/terraform/terraform-deployer (#25)

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.16.0 to 0.17.0.
- [Commits](golang/crypto@v0.16.0...v0.17.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Allow users to use env-vars for some values

* Allow users to use env-vars for some values

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Angel Montero <angelmontero@google.com>
Co-authored-by: nateaveryg <103460947+nateaveryg@users.noreply.github.com>
Co-authored-by: Dave Dorbin <ddorbin@google.com>
Co-authored-by: Riccardo Carlesso <palladiusbonton@gmail.com>
Co-authored-by: edwardthiele <4979401+edwardthiele@users.noreply.github.com>
Co-authored-by: Edward Thiele <edwardth@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattsanta mattsanta mattsanta approved these changes

Assignees

@alphanota alphanota

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alphanota @mattsanta