Support using env vars when configuring verify-evaluate-cloud-metrics#40
Merged
Conversation
* Introduce sample Terraform custom target implementation and quickstart * Fix terraform deployer module name, params comment, and build and register script perm * Add disclaimer in terraform readme indicating that the sample is not an officially supported Google product * Remove cloudbuild.yaml and build and register script temporarily * Update terraform sample with changes required to include the images commit sha in metadata * Fix module dependency version in terraform deployer * Fix the COMMIT_SHA. (And simplify it a little.) * Update the appearance of the build_and_register output The primary log lines are now green and start with ">> ". * Add clone repo instructions to terraform quickstart and readme in the custom target directory * Doc updates for Terraform sample and using const for sample commit sha metadata key * Add gitops custom target sample * Git Deployer sample: set username and email in git config after cloning the repo * Git deployer: set <> as the email in the git config if not provided * GitOps sample: Update README and QUICKSTART and added customTarget/gitEnablePullRequestMerge deploy parameter * Add docker build for each sample in presubmit.yaml --------- Co-authored-by: Michael Plump <plumpy@google.com>
* make some fixes to use new clouddeploy module * use new clouddeploy gcs methods to download manifest configuration * fix clouddeploy.yaml to use template * addalias fixes * fix gcs download paths * Supported deploy parameters are stored using customTarget/ prefix * fix configPath description * fix README,quickstart, add copyright to clouddeploy.yaml * Add copyright to more config files * address comments in request.go * address most deploy comments * address render, deploy comments. Split vertex-ai methods to its own file to make render/deploy files easier to read. Moving polling functions to its own functions as well * Add copy repo step as first step * typos and grammar * typo fixe in quickstart * expands comments for render.go * add comments on vertex ai * Create presubmit.yaml (#17) * Add sample implementation of a GitOps custom target (#14) * Introduce sample Terraform custom target implementation and quickstart * Fix terraform deployer module name, params comment, and build and register script perm * Add disclaimer in terraform readme indicating that the sample is not an officially supported Google product * Remove cloudbuild.yaml and build and register script temporarily * Update terraform sample with changes required to include the images commit sha in metadata * Fix module dependency version in terraform deployer * Fix the COMMIT_SHA. (And simplify it a little.) * Update the appearance of the build_and_register output The primary log lines are now green and start with ">> ". * Add clone repo instructions to terraform quickstart and readme in the custom target directory * Doc updates for Terraform sample and using const for sample commit sha metadata key * Add gitops custom target sample * Git Deployer sample: set username and email in git config after cloning the repo * Git deployer: set <> as the email in the git config if not provided * GitOps sample: Update README and QUICKSTART and added customTarget/gitEnablePullRequestMerge deploy parameter * Add docker build for each sample in presubmit.yaml --------- Co-authored-by: Michael Plump <plumpy@google.com> * build the model deployer in the presubmit * make changes to quickstart and readme to include information about add-alias feature in cloud deploy hook * fix replace variables script * more fixes * include add alias feature in vertex ai quick start * removing spacing between err declaration and handling * address comments * configPath points to file rather than directory * address comments --------- Co-authored-by: edwardthiele <4979401+edwardthiele@users.noreply.github.com> Co-authored-by: Matt Santa <mattsanta@google.com> Co-authored-by: Michael Plump <plumpy@google.com>
…18) * Introduce sample Terraform custom target implementation and quickstart * Fix terraform deployer module name, params comment, and build and register script perm * Add disclaimer in terraform readme indicating that the sample is not an officially supported Google product * Remove cloudbuild.yaml and build and register script temporarily * Update terraform sample with changes required to include the images commit sha in metadata * Fix module dependency version in terraform deployer * Fix the COMMIT_SHA. (And simplify it a little.) * Update the appearance of the build_and_register output The primary log lines are now green and start with ">> ". * Add clone repo instructions to terraform quickstart and readme in the custom target directory * Doc updates for Terraform sample and using const for sample commit sha metadata key * Introduce sample Infrastructure Manager custom target implementation and quickstart * Pass project ID when describing image in shared custom target build and register script * Add infrastructure manager sample to presubmit.yaml * Infrastructure Manager sample: Add Cloud Deploy UI URLs to quickstart * Update readme and quickstart for infrastruture manager sample --------- Co-authored-by: Michael Plump <plumpy@google.com>
The shebang line needs to be the in the first line of the file (above copyright).
updated command to create first release. The command had an underscore between delivery and pipeline instead of a dash. Also, added a second - in front of the word "delivery"
Corrects misleading word in readme for basic-deploy sample
forgot a space
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for env vars as params to the verify job
This allows skaffold configs like: