This repository was archived by the owner on Apr 14, 2022. It is now read-only.
Add Express5 alpha mock#98
Closed
cristiancavalli wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Closed
Add Express5 alpha mock#98cristiancavalli wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
cristiancavalli wants to merge 1 commit intoGoogleCloudPlatform:masterfrom
Conversation
- Existing Express error extraction machinery
works with Express5 in its current state.
- Add a server mock so that compatibility can
be tested over time.
- Add `npm-install-version` as development dependency
to manage Express5 usage in server mock.
Contributor
Author
|
@GoogleCloudPlatform/node-team PTAL |
ofrobots
reviewed
Feb 14, 2017
Contributor
ofrobots
left a comment
ofrobots
left a comment
There was a problem hiding this comment.
I am trying to understand how this gets used by the tests? Would this get used during npm run tests or npm run integration-tests? Can you point me to the mechanism?
| app.use(bodyParser.json()); | ||
|
|
||
| app.post( | ||
| '/testErrorHandling' |
Contributor
There was a problem hiding this comment.
nit: this file doesn't seem to follow the style we normally use.
Contributor
There was a problem hiding this comment.
actually all of the other files in the directory don't follow the style either, so can be addressed in a follow-on PR.
Contributor
|
Any further work in this area will be done in the google-cloud-node/error-reporting repository and is being tracked by issue 2294 in that repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
works with Express5 in its current state.
be tested over time.
npm-install-versionas development dependencyto manage Express5 usage in server mock.