Provide --cache-repo as OCI image layout path#2250
Provide --cache-repo as OCI image layout path#2250imjasonh merged 3 commits intoGoogleContainerTools:mainfrom
--cache-repo as OCI image layout path#2250Conversation
- Adds cache.LayoutCache to implement cache.LayerCache interface - When opts.CacheRepo has "oci:" prefix, instantiates a LayoutCache Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
|
|
||
| cacheFlag := "--cache=true" | ||
|
|
||
| for dockerfile := range d.TestCacheDockerfiles { |
There was a problem hiding this comment.
I may be missing something, but this function is called inside a for loop that also ranges over TestCacheDockerfiles.
| testutil.CheckErrorAndDeepEqual(t, false, err, want, got) | ||
| } | ||
|
|
||
| var calledExecCommand = []bool{} |
There was a problem hiding this comment.
This was never getting mutated anywhere except setCalledFalse
| } | ||
| CheckPushPermissions(&opts) | ||
| for i, shdCall := range test.ShouldCallExecCommand { | ||
| if i < len(calledExecCommand) && shdCall != calledExecCommand[i] { |
There was a problem hiding this comment.
Because calledExecCommand is never mutated, it is always 0 length, and this statement is always false; I wasn't exactly sure what this was originally supposed to be testing, but I added checkPushPermsCallCount to give some more coverage.
imjasonh
left a comment
imjasonh
left a comment
There was a problem hiding this comment.
LGTM, some small nits that you can choose to ignore if you'd rather not.
Thanks for your patience, and sorry this took so long to get around to.
|
Thanks @imjasonh! I'll make the changes you suggested... will push up a new commit shortly. |
Signed-off-by: Natalie Arellano <narellano@vmware.com>
2 participants
Description
Adds the ability to provide
--cache-repoas an OCI image layout path to cache layers on disk.This is useful if you want to avoid providing registry credentials to kaniko (when used together with
--cache-dir.Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
--cache-repoas an OCI image layout path to cache layers on disk