Merged
Conversation
added 14 commits
June 29, 2022 14:06
- Remove the platform/launch package as it is not needed to avoid having the launcher depend on the lifecycle Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
This way changes from the first build (/layers/config/metadata.toml, /layers/sbom, etc.) are not propagated to the second build. Signed-off-by: Natalie Arellano <narellano@vmware.com>
…context Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Refactor buildpack build, detect, and generate to separate data model from service Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
extensions-phase-2
branch
5 times, most recently
from
aad8930 to
53338d1
Compare
added 2 commits
September 1, 2022 16:51
Signed-off-by: Natalie Arellano <narellano@vmware.com>
This leads to incorrect permissions issues when running on linux Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
extensions-phase-2
branch
from
53338d1 to
4667bed
Compare
added 12 commits
September 14, 2022 11:52
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
… from a remote registry Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
- Fix acceptance by adding CacheRunLayers option and moving 'ARG build_id=0' statements Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
extensions-phase-2
branch
from
3fd7bbb to
9e3266e
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
extensions-phase-2
branch
from
9e3266e to
5702077
Compare
* Add Dockerfile Validation Signed-off-by: Ozzy Osborne <bardweller@gmail.com> * use mobi buildkit dockerfile parsing Signed-off-by: Ozzy Osborne <bardweller@gmail.com> Signed-off-by: Ozzy Osborne <bardweller@gmail.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
Signed-off-by: Natalie Arellano <narellano@vmware.com>
jabrown85
approved these changes
Oct 6, 2022
Contributor
jabrown85
left a comment
jabrown85
left a comment
There was a problem hiding this comment.
This is looking pretty great! I haven't had hands on extending anything myself at this point, but this is a great amount of work
added 2 commits
October 6, 2022 10:03
- Test ReadGroup for extensions - Ensure stderr is captured for acceptance test that might expect it - Read group.toml into an accurate struct (that has extension and optional set for extensions) and set these fields to false before writing out to TOML or JSON Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
extensions-phase-2
branch
from
23fef05 to
1ba40c3
Compare
Signed-off-by: Natalie Arellano <narellano@vmware.com>
natalieparellano
force-pushed
the
extensions-phase-2
branch
from
1ba40c3 to
42a92fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This still has many TODOs (of varying importance) but hopefully this branch can provide visibility into the current state of the work.
The most uncertain obstacle at this point to merging would be (a) general consensus on (forthcoming) spec PRs describing phase 2 changes, and (b) trying to get kaniko changes merged upstream.
What's left to do:
build_idas a UUID in Dockerfile build args (extender.go and extender_test.go)selective.Appendandselective.Write(selective/write.go)--cache-repoas OCI image layout path GoogleContainerTools/kaniko#2250 merged