Bug fix: mobile language switcher controls breaking on mobile#408
Merged
Conversation
✅ Deploy Preview for abgov-ui-component-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a mobile layout issue where language switcher controls in the microsite header were overlapping with app header menu elements on mobile devices. The fix ensures proper vertical stacking of language switcher elements on mobile.
- Removed tooltips from version and language switchers to simplify mobile layout
- Updated CSS to stack language switcher elements vertically on mobile instead of horizontally
- Adjusted spacing and margins for better mobile presentation
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| version-language-switcher.css | Added mobile-responsive CSS rules for proper vertical stacking and spacing adjustments |
| VersionLanguageSwitcher.tsx | Removed tooltip wrappers and added container div for better layout control |
| HelpButton.tsx | Updated tooltip text and adjusted margins for mobile layout |
twjeffery
force-pushed
the
thomasjeffery/mobile-language-switcher-fix
branch
from
20da911 to
17e50a8
Compare
bdfranck
approved these changes
Jul 23, 2025
Collaborator
bdfranck
left a comment
bdfranck
left a comment
There was a problem hiding this comment.
I looked at the deploy preview...
- ✅ I can use the React/Angular menu on mobile
- ✅ I can use the Version menu on mobile
Looks good to me! 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: language switcher controls on mobile menu in microsite header breaks on mobile, overlaps with app header menu
Fix: language switcher controls on mobile menu in microsite header stacks correctly on mobile