Skip to content

Bug fix: mobile language switcher controls breaking on mobile #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
twjeffery merged 1 commit into from
Jul 23, 2025
Merged

Bug fix: mobile language switcher controls breaking on mobile #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/components/version-language-switcher/HelpButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ export function HelpButton() {
};

return (
<GoabTooltip content="More information">
<GoabIconButton ml={"s"}
mr={"s"}
<GoabTooltip content="Version and framework info">
<GoabIconButton ml={"xs"}
mb={"2xs"}
variant="color"
size="small"
icon="help-circle"
Expand Down
8 changes: 3 additions & 5 deletions src/components/version-language-switcher/VersionLanguageSwitcher.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import {
GoabIcon,
GoabPopover, GoabTooltip
GoabPopover
} from "@abgov/react-components";
import {
ANGULAR_VERSIONS, getVersionedUrlPath, Language, LanguageVersion,
Expand Down Expand Up @@ -103,7 +103,7 @@ export const VersionLanguageSwitcher = () => {

return (
<>
<GoabTooltip content="Framework">
<div className="version-language-switcher">
<GoabPopover
target={
<a className="version-language-switcher__heading" href="#" id="language-switcher" onClick={e => openLanguagePopOver(e)}>
Expand All @@ -119,9 +119,7 @@ export const VersionLanguageSwitcher = () => {
}
</>
</GoabPopover>
</GoabTooltip>

<GoabTooltip content="Version">
<GoabPopover target={
<a className="version-language-switcher__heading" href="#"
onClick={e => openVersionPopOver(e)}>
Expand All @@ -136,7 +134,7 @@ export const VersionLanguageSwitcher = () => {
))}
</>
</GoabPopover>
</GoabTooltip>
</div>
</>
);
}
22 changes: 19 additions & 3 deletions src/components/version-language-switcher/version-language-switcher.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
align-items: center;
gap: var(--goa-space-2xs);
font-size: var(--goa-font-size-2);
margin-left: var(--goa-space-m);
white-space: nowrap;
height: 20px;
}
Expand All @@ -30,13 +29,30 @@
align-items: center; /* vertically align content */
}

.version-language-switcher {
height: 20px;
display: flex;
flex-direction: row;
Comment thread
twjeffery marked this conversation as resolved.
align-items: center; /* vertically align content */
gap: var(--goa-space-s);
margin-bottom: var(--goa-space-xs);
}

@media (max-width: 623px) {
[slot="version"] {
display: flex; /* if needed to align items horizontally */
flex-direction: column;
flex-direction: row;
align-items: flex-start;
gap: 2px;
gap: 0;
margin-top: 0;
height: auto;
}

.version-language-switcher {
height: auto;
flex-direction: column;
align-items: flex-start;
gap: 0;
margin-bottom: var(--goa-space-3xs);
}
}