Skip to content

feat(#3569): fix the PushDrawer open prop so the docs site works#3542

Merged
chrisolsen merged 1 commit into
devfrom
eric/3526/push-drawer-docs
Mar 10, 2026
Merged

feat(#3569): fix the PushDrawer open prop so the docs site works#3542
chrisolsen merged 1 commit into
devfrom
eric/3526/push-drawer-docs

Conversation

@willcodeforcoffee
Copy link
Copy Markdown
Collaborator

@willcodeforcoffee willcodeforcoffee commented Mar 6, 2026 •
edited
Loading

This fixes how the PushDrawer open prop is propagated. This could be a bigger bug, but the main reason for this PR is that the Code Sandbox for the v1 docs will keep the open prop on the base control, which Svelte interprets as a "true".
This copies what the GoabDrawer does., and the PushDrawer's heading attribute.

Before (the change)

The Push Drawer on the docs site is always open.

After (the change)

The Push Drawer on the docs site opens and closes with the controls and functions properly.

Make sure that you've checked the boxes below before you submit the PR

  • I have read and followed the setup steps
  • I have created necessary unit tests
  • I have tested the functionality in both React and Angular.

Steps needed to test

Most obviously, the http://localhost:4201/features/2469 tests still work.

To test the Docs site:

Build this branch
Run the following commands:

  • npm i
  • npm run build:prod
  • cd dist/libs/react-components
  • npm pack

Pull the eric/2469-push-drawer-docs branch: GovAlta/ui-components-docs#471

  • open package.json
  • replace "@abgov/react-components": "6.11.0", with "@abgov/react-components": "../ui-components/dist/libs/react-components/abgov-react-components-0.0.1.tgz",
  • npm i

Then go to http://localhost:5173/components/push-drawer#code-playground.

  • the drawer will only open when the "Open Drawer" button is clicked
  • the drawer will close when the "Close Drawer" and other "Close" buttons are clicked

@willcodeforcoffee willcodeforcoffee self-assigned this Mar 6, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 6, 2026 •
edited
Loading

✅ Deploy Preview for goa-design-2 ready!

Name Link
🔨 Latest commit 78193c8
🔍 Latest deploy log https://app.netlify.com/projects/goa-design-2/deploys/69ab52c864b1260008028626
😎 Deploy Preview https://deploy-preview-3542--goa-design-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@willcodeforcoffee willcodeforcoffee changed the title feat(#3569): fix the PushDraweropen prop so the docs site works feat(#3569): fix the PushDrawer open prop so the docs site works Mar 6, 2026
@willcodeforcoffee willcodeforcoffee marked this pull request as ready for review March 6, 2026 23:07
@Spark450 Spark450 requested a review from chrisolsen March 9, 2026 15:17
bdfranck
bdfranck approved these changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bdfranck bdfranck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the changes...

React Testing Playground

When I set pushDrawerOpen to true,
And I reload the browser,
I can see that the Push Drawer is open on load.

Image




When I set pushDrawerOpen to false,
And I reload the browser,
I can see that the Push Drawer is closed on load.

Image

Docs

When I navigate to the Push Drawer page,
The example drawer is closed on load.

Image

Looks good to me! 👍

@chrisolsen chrisolsen merged commit a134448 into dev Mar 10, 2026
8 checks passed
@chrisolsen chrisolsen deleted the eric/3526/push-drawer-docs branch March 10, 2026 14:41
@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 10, 2026

🎉 This PR is included in version 6.11.0-dev.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 10, 2026

🎉 This PR is included in version 1.41.0-dev.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

chrisolsen added a commit that referenced this pull request Mar 31, 2026
@chrisolsen @bdfranck
@vanessatran-ddi @dependabot @twjeffery @willcodeforcoffee @ArakTaiRoth @mxsoco
next branch release (#3720)
ce87188 
Co-authored-by: bdfranck <1479091+bdfranck@users.noreply.github.com>
Co-authored-by: Vanessa Tran <vanessa.m.tran@gov.ab.ca>
Co-authored-by: GitHub Copilot <copilot@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Benji Franck <benjamin.franck@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Thomas Jeffery <thomaswjeffery@gmail.com>
Co-authored-by: Eric Hoff <eric@highfructose.ca>
Co-authored-by: Dustin Nielsen <nielsen.dustin@gmail.com>
Co-authored-by: Thomas Jeffery <82968683+twjeffery@users.noreply.github.com>
Co-authored-by: mxsoco <miguel.soco@gov.ab.ca>
fix(#3399): correct V2 checkbox spacing behavior
fix(#3493): show tooltip on hover for Work Side Menu Group
fix(#3455,#3450): Updated top and bottom positioning for Popover
fix(#3273): keep Side Menu Group open
Closes #2893
fix the PushDrawer open prop so the docs site works (#3542)
fix: use Node 22 for Netlify deploys (#3543)
fix(#3397): use existing design tokens in Astro docs (#3515)
fix(#3581): use dynamic content collection for nav instead of hardcoded list
Closes #3581
fix(#3498): modified padding and border on radio group.
fix(#3497): fixed how the Angular Calendar and DatePicker components pass Dates to the Svelte Calendar component
fix(#3497): remove build dependency on tests using library code 
fix(#3607): update the interaction area to just around the checkbox or radio input and label
fix(#3505): Fix icon click and focus on Link
fix(#3673): docs site bug sweep - push drawer filters, side menu, multi-sort, responsive grids
Fixes workaround (chevrons hidden after #3595)
fix(#3540): add manual positioning to Popover when the browser does not support CSS anchor positioning
fix(#3614): add padding for all IconSizes
fix(#3411): audit and improve all component configuration examples
fix(#3685): adjust width of "reveal" slot for checkbox and radio buttons
fix(#3685): remove width calculation from Radio Item
@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 31, 2026

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 31, 2026

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 31, 2026

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 31, 2026

🎉 This PR is included in version 5.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Apr 1, 2026

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen chrisolsen added the released Released into production. label Apr 1, 2026
@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Apr 1, 2026

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Apr 1, 2026

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bdfranck bdfranck bdfranck approved these changes

@twjeffery twjeffery twjeffery approved these changes

@vanessatran-ddi vanessatran-ddi vanessatran-ddi approved these changes

@chrisolsen chrisolsen Awaiting requested review from chrisolsen

Assignees

@willcodeforcoffee willcodeforcoffee

Labels

released on @dev released on @next released Released into production.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@willcodeforcoffee @chrisolsen @bdfranck @twjeffery @vanessatran-ddi