Skip to content

fix: use Node 22 for Netlify deploys#3543

Merged
chrisolsen merged 1 commit into
devfrom
tom/fix-netlify-node-version
Mar 10, 2026
Merged

fix: use Node 22 for Netlify deploys#3543
chrisolsen merged 1 commit into
devfrom
tom/fix-netlify-node-version

Conversation

@twjeffery
Copy link
Copy Markdown
Collaborator

@twjeffery twjeffery commented Mar 9, 2026 •
edited
Loading

Summary

  • Netlify deploy previews are broken for branches based on the latest dev. The install step crashes before the build even starts with this error:

npm error code ERR_INVALID_ARG_TYPE
npm error The "from" argument must be of type string. Received undefined

  • Branches based on older dev still deploy fine, which is why some PRs aren't affected.
  • After troubleshooting with Claude, switching from Node 24 to Node 22 (the current stable version) fixes it. The deploy preview on this PR builds successfully.

Test plan

  • Netlify deploy preview builds successfully
  • Verify the preview site loads and pages work

@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 9, 2026 •
edited
Loading

✅ Deploy Preview for goa-design-2 ready!

Name Link
🔨 Latest commit 60ab706
🔍 Latest deploy log https://app.netlify.com/projects/goa-design-2/deploys/69af3771d9b0350008ccb8b6
😎 Deploy Preview https://deploy-preview-3543--goa-design-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@twjeffery twjeffery closed this Mar 9, 2026
@twjeffery twjeffery reopened this Mar 9, 2026
@willcodeforcoffee willcodeforcoffee mentioned this pull request Mar 9, 2026
Closed
willcodeforcoffee
willcodeforcoffee approved these changes Mar 9, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@willcodeforcoffee willcodeforcoffee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created a test PR based on a branch that wasn't deploying to Netlify at the time..
After adding the commit from this PR in a new branch it deployed to Netlify right away!
👍 LGTM, thanks Tom!

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 10, 2026

Since the issue was not one that happened all the time it is hard to verify that this is indeed a fix. As was mentioned in the meeting on previous failures on Netlify manually re-running the deploy while clearing the cache allowed the deployment to be performed successfully.

The reason why AI may have thought this worked is that when the change was made, since there was a new version of node being used, the previous failed VM for the deploy was not able to be re-used because of the new version of node, so like the manual re-run and not using the cache, the previous cached setup was cleared out and things then worked.

I will merge it and if it works that's great, but if we still have problems we might have to deal with them as we were.

@chrisolsen chrisolsen merged commit e0433ad into dev Mar 10, 2026
9 checks passed
@chrisolsen chrisolsen deleted the tom/fix-netlify-node-version branch March 10, 2026 16:50
@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 10, 2026

I am still seeing the issue on Netlify when using Node 22
image

chrisolsen added a commit that referenced this pull request Mar 31, 2026
@chrisolsen @bdfranck
@vanessatran-ddi @dependabot @twjeffery @willcodeforcoffee @ArakTaiRoth @mxsoco
next branch release (#3720)
ce87188 
Co-authored-by: bdfranck <1479091+bdfranck@users.noreply.github.com>
Co-authored-by: Vanessa Tran <vanessa.m.tran@gov.ab.ca>
Co-authored-by: GitHub Copilot <copilot@github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Benji Franck <benjamin.franck@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: Thomas Jeffery <thomaswjeffery@gmail.com>
Co-authored-by: Eric Hoff <eric@highfructose.ca>
Co-authored-by: Dustin Nielsen <nielsen.dustin@gmail.com>
Co-authored-by: Thomas Jeffery <82968683+twjeffery@users.noreply.github.com>
Co-authored-by: mxsoco <miguel.soco@gov.ab.ca>
fix(#3399): correct V2 checkbox spacing behavior
fix(#3493): show tooltip on hover for Work Side Menu Group
fix(#3455,#3450): Updated top and bottom positioning for Popover
fix(#3273): keep Side Menu Group open
Closes #2893
fix the PushDrawer open prop so the docs site works (#3542)
fix: use Node 22 for Netlify deploys (#3543)
fix(#3397): use existing design tokens in Astro docs (#3515)
fix(#3581): use dynamic content collection for nav instead of hardcoded list
Closes #3581
fix(#3498): modified padding and border on radio group.
fix(#3497): fixed how the Angular Calendar and DatePicker components pass Dates to the Svelte Calendar component
fix(#3497): remove build dependency on tests using library code 
fix(#3607): update the interaction area to just around the checkbox or radio input and label
fix(#3505): Fix icon click and focus on Link
fix(#3673): docs site bug sweep - push drawer filters, side menu, multi-sort, responsive grids
Fixes workaround (chevrons hidden after #3595)
fix(#3540): add manual positioning to Popover when the browser does not support CSS anchor positioning
fix(#3614): add padding for all IconSizes
fix(#3411): audit and improve all component configuration examples
fix(#3685): adjust width of "reveal" slot for checkbox and radio buttons
fix(#3685): remove width calculation from Radio Item
@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 31, 2026

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 31, 2026

🎉 This PR is included in version 2.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 31, 2026

🎉 This PR is included in version 7.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Mar 31, 2026

🎉 This PR is included in version 5.0.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Apr 1, 2026

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen chrisolsen added the released Released into production. label Apr 1, 2026
@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Apr 1, 2026

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@chrisolsen
Copy link
Copy Markdown
Collaborator

chrisolsen commented Apr 1, 2026

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ArakTaiRoth ArakTaiRoth ArakTaiRoth approved these changes

@willcodeforcoffee willcodeforcoffee willcodeforcoffee approved these changes

Assignees

No one assigned

Labels

released on @next released Released into production.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@twjeffery @chrisolsen @ArakTaiRoth @willcodeforcoffee