Feature/issue 146 call train config evaluation from train config generation app#147
Merged
daavoo merged 2 commits intoMay 6, 2021
Conversation
mmeendez8
commented
Apr 19, 2021
Comment on lines
+161
to
+173
| coco_ground_truth = load_ground_truth_file(ground_truth_file) | ||
|
|
||
| df_images, df_annotations = coco_ground_truth_to_dfs(coco_ground_truth) | ||
| df_images, df_annotations = coco_ground_truth_to_dfs(coco_ground_truth) | ||
|
|
||
| df_annotations = join_annotations_with_image_sizes(df_annotations, df_images) | ||
| df_annotations = join_annotations_with_image_sizes(df_annotations, df_images) | ||
|
|
||
| df_annotations = filter_zero_area_bboxes(df_annotations) | ||
| df_annotations = filter_zero_area_bboxes(df_annotations) | ||
|
|
||
| df_annotations = scale_bbox_dimensions(df_annotations, input_size=input_size) | ||
| df_annotations = scale_bbox_dimensions( | ||
| df_annotations, input_size=input_size, keep_ratio=keep_ratio | ||
| ) | ||
|
|
||
| df_annotations = get_scale_and_ratio(df_annotations, prefix="scaled") |
Contributor
Author
There was a problem hiding this comment.
These lines are repeated in train-config generation and train-config evaluation...
We might move this into a new function but not sure about where and if it is really necessary
igonro
approved these changes
Apr 26, 2021
daavoo
deleted the
feature/issue-146-Call_train-config_evaluation_from_train-config_generation_app
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #146