Ant should be api, not implementation dependency

[vlsi]

Expected and Results

Currently com.github.jengelman.gradle.plugins.shadow.transformers.Transformer is a public interface, and it has modifyOutputStream(os: org.apache.tools.zip.ZipOutputStream, preserveFileTimestamps: Boolean) method which exposes ant interface tools.zip.ZipOutputStream.

I suggest ant should be on the api scope, so the consumers can implement Transformer:

shadow/build.gradle.kts

Line 104 in 68c9f64

implementation(libs.apache.ant)

An alternative option would be replacing the parameter with java.util.zip.ZipOutputStream so ant is not needed.

Related environment and versions

No response

Reproduction steps

No response

Anything else?

No response

[Goooler]

Thanks for the reminder!

[vlsi]

Frankly, I would prefer java.util.zip.ZipOutputStream solution, however, it would break backward compatibility (==users would have to adjust their implementations), so it is not suitable for a short-term solution.

WDYT?

[Goooler]

Yeah, it will be a breaking change. And need to update a bunch of stuff if we migrate to java.util.zip.ZipOutputStream.