Expose Ant as compile scope
#1488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `org.apache.tools.zip.ZipOutputStream` is exposed in the public APIs:
```api
public class com/github/jengelman/gradle/plugins/shadow/transformers/DontIncludeResourceTransformer : com/github/jengelman/gradle/plugins/shadow/transformers/ResourceTransformer {
public fun modifyOutputStream (Lorg/apache/tools/zip/ZipOutputStream;Z)V
...
}
```
View the scope changes:
```diff
diff --color=auto -r before/shadow-gradle-plugin-9.0.0-SNAPSHOT.module after/shadow-gradle-plugin-9.0.0-SNAPSHOT.module
27a28,36
> "dependencies": [
> {
> "group": "org.apache.ant",
> "module": "ant",
> "version": {
> "requires": "1.10.15"
> }
> }
> ],
85,91d93
< "group": "org.apache.ant",
< "module": "ant",
< "version": {
< "requires": "1.10.15"
< }
< },
< {
137a140,146
> }
> },
> {
> "group": "org.apache.ant",
> "module": "ant",
> "version": {
> "requires": "1.10.15"
diff --color=auto -r before/shadow-gradle-plugin-9.0.0-SNAPSHOT.pom after/shadow-gradle-plugin-9.0.0-SNAPSHOT.pom
40c40
< <scope>runtime</scope>
---
> <scope>compile</scope>
```
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the Ant dependency (org.apache.ant:ant:1.10.15) in compile scope so that ZipOutputStream types used in public APIs are available to consumers.
- Changed Maven POM scope for Ant from
runtimetocompile. - Updated module metadata to include Ant under compile dependencies.
- Added changelog entry for the scope change.
Goooler
added a commit
that referenced
this pull request
Jun 26, 2025
(cherry picked from commit 8eeb64e)
dongjoon-hyun
added a commit
to apache/spark-kubernetes-operator
that referenced
this pull request
Jan 20, 2026
### What changes were proposed in this pull request? This PR aims to upgrade `com.gradleup.shadow` to 8.3.9. ### Why are the changes needed? To bring the latest bug fixed versions. - https://github.com/GradleUp/shadow/releases/tag/8.3.9 - GradleUp/shadow#1579 - https://github.com/GradleUp/shadow/releases/tag/8.3.8 - GradleUp/shadow#1493 - GradleUp/shadow#1488 - https://github.com/GradleUp/shadow/releases/tag/8.3.7 - GradleUp/shadow#1470 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #469 from dongjoon-hyun/SPARK-55102. Authored-by: Dongjoon Hyun <dongjoon@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
org.apache.tools.zip.ZipOutputStreamis exposed in the public APIs:View the scope changes:
Closes #1487.