Skip to content

Fix the regression of PropertiesFileTransformer in 8.3.7 #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Goooler merged 20 commits into from
Jul 1, 2025
Merged

Fix the regression of PropertiesFileTransformer in 8.3.7 #1493

Goooler merged 20 commits into from
Jul 1, 2025

Conversation

@Goooler
Copy link
Member

@Goooler Goooler commented Jul 1, 2025 •
edited
Loading

@Goooler Goooler force-pushed the g/20250701/add-tests-for-properties-trans branch from 4af57bc to 649a960 Compare July 1, 2025 08:38
@Goooler Goooler force-pushed the g/20250701/add-tests-for-properties-trans branch from 406992c to e27b5b4 Compare July 1, 2025 09:09
@Goooler Goooler linked an issue Jul 1, 2025 that may be closed by this pull request
Using PropertiesFileTransformer broken with version 8.3.7 #1483
Closed
@Goooler Goooler changed the title Test mergePropertiesWithDifferentStrategies for PropertiesFileTransformer Fix the regression of PropertiesFileTransformer in 8.3.7 Jul 1, 2025
@Goooler Goooler marked this pull request as ready for review July 1, 2025 10:45
@Goooler Goooler requested a review from Copilot July 1, 2025 10:45

This comment was marked as outdated.

Sign in to view

@Goooler Goooler force-pushed the g/20250701/add-tests-for-properties-trans branch from 52c991b to 5002ec4 Compare July 1, 2025 12:55
@Goooler Goooler force-pushed the g/20250701/add-tests-for-properties-trans branch from 5002ec4 to 605f95f Compare July 1, 2025 12:57
Goooler
Goooler commented Jul 1, 2025
View reviewed changes
...ovy/com/github/jengelman/gradle/plugins/shadow/transformers/PropertiesFileTransformer.groovy
Comment on lines 139 to 141
Closure<String> keyTransformer = IDENTITY
Closure<String> keyTransformer = new Closure<String>("") {
String doCall(Object arguments) { arguments }
}
Copy link
Member Author

@Goooler Goooler Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

    public static final Closure IDENTITY = new Closure<Object>((Object)null) {
        private static final long serialVersionUID = 730973623329943963L;

        public Object doCall(Object args) {
            return args;
        }
    };

@Goooler Goooler merged commit d59d947 into 8.x Jul 1, 2025
10 checks passed
@Goooler Goooler deleted the g/20250701/add-tests-for-properties-trans branch July 1, 2025 13:10
@dongjoon-hyun dongjoon-hyun mentioned this pull request Jan 20, 2026
Closed
dongjoon-hyun added a commit to apache/spark-kubernetes-operator that referenced this pull request Jan 20, 2026
@dongjoon-hyun
[SPARK-55102] Upgrade com.gradleup.shadow to 8.3.9
ac54fcb 
### What changes were proposed in this pull request?

This PR aims to upgrade `com.gradleup.shadow` to 8.3.9.

### Why are the changes needed?

To bring the latest bug fixed versions.
- https://github.com/GradleUp/shadow/releases/tag/8.3.9
  - GradleUp/shadow#1579
- https://github.com/GradleUp/shadow/releases/tag/8.3.8
  - GradleUp/shadow#1493
  - GradleUp/shadow#1488
- https://github.com/GradleUp/shadow/releases/tag/8.3.7
  - GradleUp/shadow#1470

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes #469 from dongjoon-hyun/SPARK-55102.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Using PropertiesFileTransformer broken with version 8.3.7

2 participants

@Goooler