Support relative time range "until" value in date time picker.#9896
Closed
linuspahl wants to merge 11 commits intofeature/DateTimeRangefrom
Closed
Support relative time range "until" value in date time picker.#9896linuspahl wants to merge 11 commits intofeature/DateTimeRangefrom
linuspahl wants to merge 11 commits intofeature/DateTimeRangefrom
Conversation
This change is implementing functionality to support an alternative way
to use relative time ranges. Instead of a `range` property that defines
the length of the range in seconds going backwards from now, it allows
defining `from` and `to` properties defining the endpoints of a range in
relation to `now`. This allows e.g. defining a range that goes from 5
minutes ago to 1 minute ago by specifying a relative range as:
```
{
"type": "relative",
"from": 300,
"to": 60
}
```
Fixes #9898.
* Create component for relative time range form group * Provide range offset on search execution
linuspahl
force-pushed
the
feature/DateTimeRange-relative-offset
branch
from
bf3b500 to
7c0b672
Compare
…teTimeRange-relative-offset
Contributor
Author
|
Closing in favour of #9946 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is based on #9899 which needs to be merged first
Description
With this PR we are enabling the "Until" field for the relative tab in the date time picker, this allows defining e.g. the following time range:
From: 5 minutes ago until 1 minute agoThere is one failing test, which also fails on
feature/DateTimeRange.