Supporting from and to properties in relative time ranges.#9899
Merged
Supporting from and to properties in relative time ranges.#9899
from and to properties in relative time ranges.#9899Conversation
This change is implementing functionality to support an alternative way
to use relative time ranges. Instead of a `range` property that defines
the length of the range in seconds going backwards from now, it allows
defining `from` and `to` properties defining the endpoints of a range in
relation to `now`. This allows e.g. defining a range that goes from 5
minutes ago to 1 minute ago by specifying a relative range as:
```
{
"type": "relative",
"from": 300,
"to": 60
}
```
Fixes #9898.
This was referenced Jan 14, 2021
kmerz
approved these changes
Jan 15, 2021
Member
kmerz
left a comment
kmerz
left a comment
There was a problem hiding this comment.
Code LGTM!
Worked on my machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This change is implementing functionality to support an alternative way to use relative time ranges. Instead of a
rangeproperty that defines the length of the range in seconds going backwards from now, it allows definingfromandtoproperties defining the endpoints of a range in relation tonow. This allows e.g. defining a range that goes from 5 minutes ago to 1 minute ago by specifying a relative range as:Fixes #9898.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: