Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8f13d7a10d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| wait "$upstream_pid" | ||
| if ! grep -Fq "KEYCLAW_SECRET_" "$body_file"; then | ||
| if ! grep -Fq "KEYCLAW_OPAQUE_" "$body_file"; then |
There was a problem hiding this comment.
The release smoke test now asserts KEYCLAW_OPAQUE_ in upstream traffic, but v2 placeholders are rendered as {{KEYCLAW_<shape>~<kind><id>}} (see make_typed in src/placeholder.rs) and do not include that literal, so a correctly redacted request will still fail this check. In scripts/smoke-release.sh, this causes false-negative smoke failures that can block release validation even when the proxy rewrite path is working.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation
cargo fmt --checkcargo clippy --all-targets --all-features -- -D warningscargo build --lockedcargo test --lockedcargo test --locked --test e2e_cli -- --ignored --test-threads=1cargo doc --no-depsDocs
docs/updated if deeper reference material changedNotes