Skip to content

Conversation

@Mec-iS
Copy link
Contributor

@Mec-iS Mec-iS commented Mar 7, 2019

No description provided.

krritik and others added 21 commits February 10, 2019 11:48
Inserting Hydra Core and Open Parser since Hydrus ported Hydraspec
Adding import to hydra_python_core after hydraspec porting
Backwards incompatibility from Redis 2 to Redis 3, which now only accepts values as bytes, strings or numbers
Changing this test slightly so the "requirements.txt" consists of everything needed to run and it won't fail because of the requirements in the current hydrus master branch.
The goal of Porting the doc writer was so that the agent supposed to depend only on hydra_python_core which is now possible.
Use 'hydra_python_core' module in place of 'hydrus.hydraspec'
Backwards incompatibility from Redis 2 to Redis 3, which now only accepts values as bytes, strings or numbers
Fixing Redis breaking change
* Added a check for trailing slash in url_input.
* Added a context manager to the load_data method
* Corrected the logger format.
@Mec-iS
Copy link
Contributor Author

Mec-iS commented Mar 7, 2019

Merge and release after #91 is merged.

@sandeepsajan0 @xadahiya please review

@Mec-iS Mec-iS requested review from sandeepsajan0 and xadahiya March 7, 2019 12:13
Copy link
Member

@xadahiya xadahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Contributor

@sandeepsajan0 sandeepsajan0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working fine!

@Mec-iS Mec-iS merged commit f8a0910 into master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants