Added semantic refs to classes #210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Contributor
Author
|
thanks @Mec-iS, i am actually working on it hence the label , as it was said to share what are we doing i opened this PR . Will change the commit messages as i agree they are horrible .About the coding cylces , i will speed it up and make sure the quality is more than acceptable . |
xadahiya
reviewed
Jun 24, 2018
hydrus/samples/hydra_doc_sample.py
Outdated
| { | ||
| "@type": "SupportedProperty", | ||
| "property": "vocab#/definitions/Category", | ||
| "property": "vocabCategory", |
Member
There was a problem hiding this comment.
Shouldn't this be vocab:Category ?
Contributor
Author
There was a problem hiding this comment.
ah , yes , fixing
Contributor
Author
|
@xadahiya ^^ |
2 tasks
vaibhavchellani
changed the title
xadahiya
requested changes
Jun 24, 2018
| doc: Dict["str",Any], | ||
| classAndClassDefinition:Dict["str",HydraClass]) -> str: | ||
| """ | ||
Member
There was a problem hiding this comment.
Some Docstrings have descriptions but lack params other have params but lack proper descriptions.
Fix this
Contributor
|
@vaibhavchellani I still don't see docstrings in the methods. As instructed different times, the code has to be compliant with PEP-8. |
Member
|
Using placeholders at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #204
Checklist
Description
Added semantic refs to classes , working on the external parser , its work in progress , please suggest changes to this .