Parsing the class location iteratively #212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
xadahiya
reviewed
Jun 22, 2018
hydrus/parser/openapi_parser.py
Outdated
| return class_location[len(class_location)-1] | ||
|
|
||
|
|
||
| def get_data_at_location(class_location, doc): |
Member
There was a problem hiding this comment.
Use mypy format and add proper DocStrings
Contributor
Author
xadahiya
reviewed
Jun 24, 2018
hydrus/parser/openapi_parser.py
Outdated
|
|
||
| def get_data_at_location(class_location: List[str], doc: Dict[str,Any]) -> Dict[str,Any]: | ||
| """ | ||
Member
There was a problem hiding this comment.
Add proper Docstrings explaining what each function does along with parameter explanations.
xadahiya
reviewed
Jun 25, 2018
hydrus/parser/openapi_parser.py
Outdated
| def parse(doc): | ||
| def parse(doc: Dict[str, Any]) -> str: | ||
| """ | ||
| parent function for parsing the open api documentation |
Member
There was a problem hiding this comment.
@vaibhavchellani You should also use proper punctuations for function explanations in Docstrings.
Contributor
Author
|
@xadahiya please let me know if there are any other changes or if the quality standards are not being met . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #211
Checklist
Description
The parser can now go to any level deep to parse class or other objects .Earlier we were only able to go 1 level deep now we are parsing iteratively to fetch data.
Test Logs