removed conditions restricting addition of only classes with paths #214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xadahiya
reviewed
Jun 22, 2018
hydrus/parser/openapi_parser.py
Outdated
| api_doc.add_supported_class(classAndClassDefinition[definitionSet[index]], collection=False) | ||
| except KeyError: | ||
| pass | ||
| generateEntrypoint(api_doc) |
Member
There was a problem hiding this comment.
You should remove generateEntrypoint() from get_paths() as it has nothing to do with parsing paths from the doc or am I missing something here?
Contributor
Author
There was a problem hiding this comment.
no you are right , but it was harmless so i left it there , moving it to parse method .
Contributor
Author
|
please merge this after PR #212 so that we can get doc strings and parameter description from that PR. |
Member
|
Please resolve the conflicts Vaibhav |
… to right location
Contributor
Author
|
@xadahiya fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #213
Checklist
Description
All the classes/ definitions that have been parsed will be added .
Test Logs
### Changes log