Added exclusion for backup-related waits to GetLongRunningQueriesAsync() method.#4
Merged
HannahVernon merged 1 commit intoFeb 27, 2026
Conversation
…c() method. Removed System.Collections.Generic using statement as it is unnecessary.
HannahVernon
added a commit
that referenced
this pull request
Mar 27, 2026
…eout - DuckDbInitializer.AcquireWriteLock() now accepts optional TimeSpan timeout to prevent indefinite blocking when archival holds the lock - DismissAlertsAsync uses exclusive write lock + single batched UPDATE with VALUES list + BEGIN/COMMIT/ROLLBACK transaction for all-or-nothing semantics - DismissAllVisibleAlertsAsync uses exclusive write lock (was read lock) - OpenWriteConnectionAsync uses 5-second timeout to prevent UI freeze - UI dismiss handlers catch TimeoutException with friendly retry message - LockedConnection updated to document both read and write lock usage - 7 new tests covering batched UPDATE, transaction commit/rollback, write lock exclusivity, and timeout behavior (225 total, all passing) Addresses items #4, #5, erikdarlingdata#11 from issue erikdarlingdata#718 improvement list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds and exclusion for backup-related waits to the
GetLongRunningQueriesAsync()method to avoid unnecessarily reporting backups as long-running. The thought here is of-course-they-are-long-running and as such don't need to be reported. Feel free to decline this if you do not agree, or perhaps make the method parameterfalseby default instead oftrue. At some point when I get around to it I intend to add these parameters to the settings dashboard for user-configurability.Which component(s) does this affect?
How was this tested?
Tested against 4 instances of SQL Server 2022 with WSFC Availability Group.
Checklist
dotnet build -c Debug)