Feature/add exclusion for backupthread to long running queries#5
Merged
HannahVernon merged 2 commits intoMar 2, 2026
Merged
Conversation
…dded miscWaitsFilter to exclude XE_LIVE_TARGET_TVF waits. Removed unused parameters. Corrected minimum value for maxLongRunningQueryCount (minimum 1 instead of 5).
HannahVernon
added a commit
that referenced
this pull request
Mar 27, 2026
…eout - DuckDbInitializer.AcquireWriteLock() now accepts optional TimeSpan timeout to prevent indefinite blocking when archival holds the lock - DismissAlertsAsync uses exclusive write lock + single batched UPDATE with VALUES list + BEGIN/COMMIT/ROLLBACK transaction for all-or-nothing semantics - DismissAllVisibleAlertsAsync uses exclusive write lock (was read lock) - OpenWriteConnectionAsync uses 5-second timeout to prevent UI freeze - UI dismiss handlers catch TimeoutException with friendly retry message - LockedConnection updated to document both read and write lock usage - 7 new tests covering batched UPDATE, transaction commit/rollback, write lock exclusivity, and timeout behavior (225 total, all passing) Addresses items #4, #5, erikdarlingdata#11 from issue erikdarlingdata#718 improvement list. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Addresses issues from PR 362 in ErikDarling/PerformanceMonitor.
BROKER_RECEIVE_WAITFORwait type towaitforFilterexclusions.miscWaitsFilterto excludeXE_LIVE_TARGET_TVFwaits.maxLongRunningQueryCount(minimum is now1instead of5).Controls/LandingPage.xaml.csWhich component(s) does this affect?
How was this tested?
Tested against local 2022 instance
Checklist
dotnet build -c Debug)