Revive stale PR for supporting path-specified parameters fixing #17#129
Open
robinp wants to merge 4 commits intoHaskell-OpenAPI-Code-Generator:masterfrom
Open
Revive stale PR for supporting path-specified parameters fixing #17#129robinp wants to merge 4 commits intoHaskell-OpenAPI-Code-Generator:masterfrom
robinp wants to merge 4 commits intoHaskell-OpenAPI-Code-Generator:masterfrom
Conversation
added 4 commits
February 1, 2026 20:25
…or#71 Original PR: Haskell-OpenAPI-Code-Generator#71 Taken over as-is, with minor cleanup and following some renames that happened in the meantime. Golden changes seems benign, but order changes due to Map use. Will clean those up and regen goldens, plus add some test case.
So no change in generated.
Member
|
Thank you for the revival 🙏 After CI passes (do you need to request a run?), this should be good to merge.
Did you get a chance to do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see commit docs.
On first hunch, seems to generate for my spec what I wanted, but will get back with some live testing later.