Sync up with react select#85
Sync up with react select#85AndreiRailean wants to merge 31 commits intoHubSpot:masterfrom AndreiRailean:sync_up_with_react_select
Conversation
* [FIX] #1651 moved option prop sync to componentWillReceiveProps * [ADD] test for option prop sync by componentWillReceiveProps
* [ADD] Clarified the onInputChange prop signature in the docs * [ADD] requested changes
Replace whitespaces with tabs and vice versa for consistency reasons
Replace whitespaces with tabs and vice versa for consistency reasons
* Update README.md to include 'valueComponent' prop Thanks to some very helpful feedback I received in this repo (and reading through some issues other users were having) I found there was a valueComponent prop that I could utilize that made my life so much easier. I think it needs to be included in the list of available props in the docs. * Update README.md to include 'valueComponent' prop (edited with suggested changes made) * Minor copy edits of valueComponent description
* hide create option after closing menu * cleaned up tests
Before this change, console log in browser will throw
> Selected: [object Object]
After this change console log in browser will throw some nice information.
> Selected: {"value":"three","label":"Three"}
Update Template to point users to SO and update plnkr
convert Select to ES6 class
convert Value to ES6 class
convert Option to ES6 class
convert CreatableSelect to ES6 class
convert AsyncCreatable to ES6 class
Typo "effeciently" => "efficiently"
* Fix issue with Circular references. Because Select was used in Async, AsyncCreatable, and Creatable and those components were ref in Select, there was a circular dependency. It seems mostackage managers handled this ok, but this may cause an issue with hoisting (e.g. rollup and webpack 3).# Please enter the commit message for your changes. Lines starting * Add focus test back in to Async * Make components static fields on Select instance
Previously, when the ignoreCase or ignoreAccents options were set to true in an Async select, the visible user input would be transformed (e.g. it would appear all lowercase even when the user was typing capital letters). This commit updates the component to transform the input internally without changing the input value itself.
Avoid mutating user input when ignoring case/accents (fixes #1352)
remove create-react-class dependency from main sources
Update README.md
|
Out of sheer curiosity: is there any reason for developing this component as a separate project instead of making a PR to the original JedWatson/react-select ? |
|
My understanding is that JedWatson is very picky about the features he wants to have in react-select. Have a look at the number of issues and pull requests on react-select repo to understand why someone may find it easier to fork. |
Here's the ticket for option groups in JedWatson/react-select: JedWatson/react-select#59 We'd be thrilled to see JedWatson/react-select incorporate the features we need. We've always hoped that this fork would be a temporary solution. Unfortunately, development on JedWatson/react-select has largely stalled for the time being. |
|
As to this ticket, I appreciate it but won't have time to review it until next week. Thank you for your patience. |
|
Last comment was several months ago - any update on syncing with react-select? |
|
Sorry for the delay here. I have an open PR to sync up with react-select RC10: #96 Any eyes on that branch would be appreciated! |
15 participants
Merge latest master of react-select into react-select-plus
Manually resolved conflicts.
yarn testhad no errors.Not sure what other steps are required to make it mergeable.
Doing my part to keep two projects in sync.