Update to JedWatson/react-select v1.0.0-rc.10#96
Merged
TrevorBurnham merged 124 commits intomasterfrom Oct 20, 2017
Merged
Conversation
* [FIX] #1651 moved option prop sync to componentWillReceiveProps * [ADD] test for option prop sync by componentWillReceiveProps
* [ADD] Clarified the onInputChange prop signature in the docs * [ADD] requested changes
Replace whitespaces with tabs and vice versa for consistency reasons
Replace whitespaces with tabs and vice versa for consistency reasons
* Update README.md to include 'valueComponent' prop Thanks to some very helpful feedback I received in this repo (and reading through some issues other users were having) I found there was a valueComponent prop that I could utilize that made my life so much easier. I think it needs to be included in the list of available props in the docs. * Update README.md to include 'valueComponent' prop (edited with suggested changes made) * Minor copy edits of valueComponent description
* hide create option after closing menu * cleaned up tests
Before this change, console log in browser will throw
> Selected: [object Object]
After this change console log in browser will throw some nice information.
> Selected: {"value":"three","label":"Three"}
Update Template to point users to SO and update plnkr
convert Select to ES6 class
convert Value to ES6 class
convert Option to ES6 class
convert CreatableSelect to ES6 class
convert AsyncCreatable to ES6 class
Typo "effeciently" => "efficiently"
* Fix issue with Circular references. Because Select was used in Async, AsyncCreatable, and Creatable and those components were ref in Select, there was a circular dependency. It seems mostackage managers handled this ok, but this may cause an issue with hoisting (e.g. rollup and webpack 3).# Please enter the commit message for your changes. Lines starting * Add focus test back in to Async * Make components static fields on Select instance
Fix peerDependencies to be compatible with 'prop-types' package
This behaviour is default now, and implemented in the Select component itself. Use closeOnSelect={false} and onSelectResetsInput={false} to leave the suggestions open.
Fix clearable padding style
Resolves PropType deprecation warning
Fix scroll focus when using up arrow key
Remove obsolete browserify-shim configuration
Remove obsolete browserify-shim configuration
fix bug, if wrote "hasOwnProperty"
This was referenced Oct 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #93, #94, #95.
Lots of changes here, as our last sync-up was with RC5: #76