Fix create-react-class and prop-types references in UMD build#87
Closed
banderson wants to merge 1 commit intoHubSpot:masterfrom
banderson:fix-umd-build
Closed
Fix create-react-class and prop-types references in UMD build#87banderson wants to merge 1 commit intoHubSpot:masterfrom banderson:fix-umd-build
banderson wants to merge 1 commit intoHubSpot:masterfrom
banderson:fix-umd-build
Conversation
Contributor
|
This could function as a workaround for our internal build issue, but at the expense of inducing a deprecation warning in React 15.5 and breaking the project entirely in React 16. Surely there must be a way to define a |
Contributor
|
@banderson react-select has significantly changed their build process since we last looked at this. Those changes will come in to react-select-plus once #96 is merged. Let's reassess after that's merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@TrevorBurnham I found the issue with the
react-create-classdependency, it turns out we had to update the browserify config to point to the global before we build the UMD. This gets things working again for me locally.