Small typing fixes#590
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #590 +/- ##
=======================================
Coverage 97.48% 97.48%
=======================================
Files 85 85
Lines 8105 8105
=======================================
Hits 7901 7901
Misses 204 204
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
AdamGleave
approved these changes
Oct 25, 2022
Member
There was a problem hiding this comment.
LGTM.
Small PRs are fine -- preferable, in fact, easy to review. 3 lines is admittedly on the smaller end of a small PR, but feel free to just send these across as they come up.
Not sure why pytype was failing for you bot not on CI; I'm guessing version issue? But adding NoReturn seems like the right thing to do regardless.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes some typing issues that arose on a fresh install:
preference_comparison.py:imitation/src/imitation/algorithms/preference_comparisons.py
Line 773 in 944edce
var_estimateis defined in the previous code branches, except one, which callsraise_uncertainty_on_not_supportedwhich raises an error, and this requires an explicit type annotation to indicate thatThis is a very small PR, so I can add more typing fixes where I notice them to add some more substance, if desired.
Testing
ci/code_checks.sh, which failed on a fresh install, now passes