Skip to content

Small typing fixes #590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AdamGleave merged 1 commit into from
Oct 25, 2022
Merged

Small typing fixes #590

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
# TODO: upgrade jupyter-client once
# https://github.com/jupyter/jupyter_client/issues/637 is fixed
"jupyter-client~=6.1.12",
"mypy==0.971",
"mypy~=0.981",
"pandas~=1.4.3",
"pytest~=7.1.2",
"pytest-cov~=3.0.0",
Expand Down
3 changes: 2 additions & 1 deletion src/imitation/algorithms/preference_comparisons.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
List,
Mapping,
NamedTuple,
NoReturn,
Optional,
Sequence,
Tuple,
Expand Down Expand Up @@ -707,7 +708,7 @@ def __init__(
def uncertainty_on(self) -> str:
return self._uncertainty_on

def raise_uncertainty_on_not_supported(self):
def raise_uncertainty_on_not_supported(self) -> NoReturn:
raise ValueError(
f"""{self.uncertainty_on} not supported.
`uncertainty_on` should be from `logit`, `probability`, or `label`""",
Expand Down