Skip to content

Add model for PAF reviewers role, add dashboard view for contracting role #2927

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sandeepsajan0 wants to merge 17 commits into from
Closed

Add model for PAF reviewers role, add dashboard view for contracting role #2927

sandeepsajan0 wants to merge 17 commits into from

Conversation

@sandeepsajan0
Copy link
Member

@sandeepsajan0 sandeepsajan0 commented Jul 15, 2022 •
edited
Loading

@sandeepsajan0 sandeepsajan0 marked this pull request as ready for review July 19, 2022 06:56
@codecov
Copy link

codecov bot commented Jul 20, 2022 •
edited
Loading

Codecov Report

Base: 81.97% // Head: 81.93% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (f4fc77d) compared to base (7374b8d).
Patch coverage: 92.61% of modified lines in pull request are covered.

❗ Current head f4fc77d differs from pull request most recent head 4fa2228. Consider uploading reports for the commit 4fa2228 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2927      +/-   ##
==========================================
- Coverage   81.97%   81.93%   -0.04%     
==========================================
  Files         704      683      -21     
  Lines       24958    24992      +34     
==========================================
+ Hits        20459    20477      +18     
- Misses       4499     4515      +16
Impacted Files Coverage Δ
hypha/apply/projects/admin.py 75.00% <ø> (ø)
hypha/apply/projects/forms/__init__.py 100.00% <ø> (ø)
hypha/apply/projects/views/__init__.py 100.00% <ø> (ø)
hypha/apply/dashboard/views.py 75.44% <35.29%> (-4.56%) ⬇️
...ypha/apply/projects/templatetags/approval_tools.py 71.42% <56.25%> (-28.58%) ⬇️
hypha/apply/projects/models/project.py 90.97% <86.11%> (-1.31%) ⬇️
hypha/apply/projects/views/project.py 87.87% <95.16%> (+0.27%) ⬆️
hypha/apply/funds/admin.py 85.34% <100.00%> (+0.12%) ⬆️
hypha/apply/projects/forms/project.py 98.37% <100.00%> (+0.04%) ⬆️
.../0054_paf_reviewers_roles__alter_project_status.py 100.00% <100.00%> (ø)
... and 68 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@frjo
Copy link
Member

frjo commented Jul 21, 2022

This is on test now.

@frjo frjo added Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter labels Jul 21, 2022
theskumar
theskumar reviewed Jul 21, 2022
View reviewed changes
hypha/apply/dashboard/templates/dashboard/contracting_dashboard.html
<script src="{% static 'js/apply/submission-filters.js' %}"></script>
<script src="{% static 'js/apply/submission-tooltips.js' %}"></script>
<script src="{% static 'js/apply/tabs.js' %}"></script>
{% endblock %}
Copy link
Member

@theskumar theskumar Jul 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why not have these in the base-apply.html if there is no custom javascript code written for the functionalities added to this page. @sandeepsajan0

@sandeepsajan0 sandeepsajan0 mentioned this pull request Aug 9, 2022
Merged
@sandeepsajan0 @frjo
Update Dasboards for finance and contracting
ab4f428
@sandeepsajan0 @frjo
Add model for PAF reviewers roles, and manage permissions for contrac…
1d62afe 
…ting and finance
@sandeepsajan0 @frjo
Add PAF status Change form and view with dynamic roles
d55f9eb
@sandeepsajan0 @frjo
Fix Send for Approval view test
6c90fa2
@sandeepsajan0 @frjo
Update users role in approval form tests
1446093
@sandeepsajan0 @frjo
Add request change functionality, send to compliance mail, and added …
09ec9cf 
…notifications
@sandeepsajan0 @frjo
fix update status permissions
a20edbc
@sandeepsajan0 @frjo
Add update status form(request change option) for final approver of p…
af7be0f 
…roject
@sandeepsajan0 @frjo
Make comments and actions non-editable
a9c71a3
@sandeepsajan0 @frjo
Fix existing tests of Final approval form
0b206a3
@sandeepsajan0 @frjo
Remove RejectionView from projects
43455e5
@sandeepsajan0 @frjo
Remove RejectionForm and its tests, and Move ProjectApprovalForm from…
f6aa5cb 
… Manage section to Apply section in admin ui
@sandeepsajan0 @frjo
Update tests for FinalApproval and PAFStatus Views and forms
470aeb8
@sandeepsajan0 @frjo
resolve lint issues
9e1eeff
@sandeepsajan0 @frjo
Fix tests for roles by creating PafReviewerRoles via settings
7ad3f01
@sandeepsajan0 @frjo
Serve fancybox and search param js file locally
3afeef4
@frjo frjo force-pushed the feature-project-approval-form branch from f4fc77d to 3afeef4 Compare August 29, 2022 08:06
@frjo
Copy link
Member

frjo commented Aug 29, 2022 •
edited
Loading

@sandeepsajan0 Looks like this can be closed since we have #2943

@frjo frjo closed this Aug 29, 2022
@frjo frjo deleted the feature-project-approval-form branch December 7, 2022 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theskumar theskumar theskumar left review comments

Assignees

No one assigned

Labels

Type: Feature This is something new (not an enhancement of an existing thing). Type: Minor Minor change, used in release drafter

Projects

None yet

Milestone

No milestone

4 participants

@sandeepsajan0 @frjo @theskumar