snapshot initial code#16
Open
meghnasiingh wants to merge 12 commits intomasterfrom
Open
Conversation
added 7 commits
December 21, 2021 09:05
Signed-off-by: Meghna Singh <meghna@Meghnas-MacBook-Pro.local>
meghnasiingh
commented
Feb 1, 2022
|
|
||
| // CreateSnapshot on the volume | ||
| func (volprov *DefaultVolumeProvider) CreateSnapshot(volume *Volume, tags map[string]string) (*Snapshot, error) { | ||
| func (volprov *DefaultVolumeProvider) CreateSnapshot(snapshotRequest SnapshotRequest) (*Snapshot, error) { |
Contributor
Author
There was a problem hiding this comment.
input parameter (mandatory, opts)
e.g, (vol-id, opts(name, tags, resource_group))
Contributor
Author
There was a problem hiding this comment.
get the resource group from vpc session
meghnasiingh
commented
Feb 1, 2022
| // Snapshot ... | ||
| type Snapshot struct { | ||
| Volume | ||
| VolumeID string `json:"volumeID,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
href is also required.
meghnasiingh
commented
Feb 1, 2022
| SnapshotTags SnapshotTags `json:"tags,omitempty"` | ||
|
|
||
| // status of snapshot | ||
| ReadyToUse bool `json:"readyToUse,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
Check for omitempty. update whereever required
meghnasiingh
commented
Feb 1, 2022
|
|
||
| // Source volume details | ||
| //SnapshotedVolume *Volume `json:"SnapshotedVolume"` | ||
| SnapshotSize int64 `json:"snapshotSize,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
make comment it will be in Bytes
Contributor
Author
There was a problem hiding this comment.
convert to byte and return , not omitempty
meghnasiingh
commented
Feb 1, 2022
| } | ||
|
|
||
| // SnapshotRequest ... | ||
| type SnapshotRequest struct { |
Contributor
Author
There was a problem hiding this comment.
snapshot request --> snapshot parameter
meghnasiingh
commented
Feb 1, 2022
|
|
||
| //GetSnapshotWithVolumeID gets the snapshot with volumeID | ||
| func (volprov *DefaultVolumeProvider) GetSnapshotWithVolumeID(volumeID string, snapshotID string) (*Snapshot, error) { | ||
| //GetSnapshotByName gets the snapshot |
Contributor
Author
There was a problem hiding this comment.
consider resource group also
meghnasiingh
force-pushed
the
snapshot
branch
from
ee72140 to
20728b8
Compare
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com>
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com>
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com>
meghnasiingh
commented
Feb 15, 2022
| ReadyToUse bool `json:"readyToUse"` | ||
|
|
||
| // VPC contains vpc fields | ||
| VPC *VPC `json:"vpc"` |
Contributor
Author
There was a problem hiding this comment.
Make vpc field as volume
meghnasiingh
commented
Feb 15, 2022
| // SnapshotParameters ... | ||
| type SnapshotParameters struct { | ||
| // Name of snapshot | ||
| Name *string `json:"name,omitempty"` |
Contributor
Author
There was a problem hiding this comment.
check if we can remove string pointer
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com>
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Meghna Singh meghna@Meghnas-MacBook-Pro.local