Conversation
sameshai
approved these changes
Aug 9, 2022
ambiknai
commented
Sep 12, 2022
| //SnapshotedVolume *Volume `json:"SnapshotedVolume"` | ||
| // The size of the snapshot, in bytes | ||
| SnapshotSize int64 `json:"snapshotSize"` | ||
|
|
Member
Author
There was a problem hiding this comment.
size* | integerminimum: 1The size of this snapshot rounded up to the next gigabyte
So it is int64
Member
Author
There was a problem hiding this comment.
ambiknai
commented
Sep 12, 2022
|
|
||
| // SnapshotList ... | ||
| type SnapshotList struct { | ||
| Next string `json:"next,omitempty"` |
Member
Author
There was a problem hiding this comment.
Remove omitempty. Check.
ambiknai
commented
Sep 12, 2022
ambiknai
commented
Sep 12, 2022
ambiknai
commented
Sep 12, 2022
arahamad
approved these changes
Sep 14, 2022
Signed-off-by: Meghna Singh <meghna@Meghnas-MacBook-Pro.local> Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com> Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com> Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com> Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com> Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
Signed-off-by: Meghna Singh <Meghna.Singh1@ibm.com> Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
Signed-off-by: Ambika Nair <ambiknai@in.ibm.com>
ambiknai
force-pushed
the
snapshotmerge
branch
from
6c6809b to
2359113
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Orginal PR by @meghnasiingh : #16