117- Create use case to get the file citation#125
Conversation
|
Waiting on IQSS/dataverse#10240 |
There was a problem hiding this comment.
This looks good! I just have a question about what dataset version should be returned by default, it seems that JSF returns :latest-published, but we are returning :latest. See Slack thread https://iqss.slack.com/archives/C06FWJ0FV2R/p1707935795390489
|
@ekraffmiller I updated the code to set :latest-published as the default version to match JSF behavior as you suggested |
|
@MellyGray since we are creating an action item for fixing the default version shown as discussed here https://iqss.slack.com/archives/C06FWJ0FV2R/p1708016216373459, I think it's ok to keep everything as :latest, what do you think? Since our ultimate solution will be changing this logic anyway. |
|
I'm removing the waiting label because this pull request was just merged: |
ekraffmiller
left a comment
There was a problem hiding this comment.
Looks good, approved!
What this PR does / why we need it:
This PR adds a new use case getFileCitation to get the file citation given the fileId and datasetVersion.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
GetFileCitation use case added to the module
Additional documentation: