Conversation
This comment has been minimized.
This comment has been minimized.
926ebfb to
5214d7b
Compare
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
286657f to
f34f82b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
GPortas
reviewed
Jan 24, 2024
GPortas
reviewed
Jan 24, 2024
GPortas
reviewed
Jan 24, 2024
GPortas
reviewed
Jan 24, 2024
GPortas
reviewed
Jan 24, 2024
GPortas
reviewed
Jan 24, 2024
GPortas
reviewed
Jan 24, 2024
GPortas
reviewed
Jan 24, 2024
GPortas
reviewed
Jan 24, 2024
GPortas
reviewed
Jan 24, 2024
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Conflicts: src/test/java/edu/harvard/iq/dataverse/api/FilesIT.java
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@GPortas et al., I'm ready for more review. Thanks for all the feedback so far! |
This comment has been minimized.
This comment has been minimized.
GPortas
reviewed
Feb 15, 2024
| } | ||
|
|
||
| @Test | ||
| public void testFileCitationToStringHtmlFilePid() throws ParseException { |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
Contributor
|
@pdurbin, Should I be worried that https://dataverse-guide--10246.org.readthedocs.build/en/10246/api/native-api.html#get-file-citation-as-json looks like this in Safari? |
Member
Author
|
@sekmiller huh. I can't reproduce it. It shouldn't have anything to do with this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What this PR does / why we need it:
Returns a file citation like this:
This will be used by the the file landing page in the new frontend. See IQSS/dataverse-client-javascript#117
Which issue(s) this PR closes:
Special notes for your reviewer:
As requested in the issue, I followed the conventions in for the dataset-level equivalent of getting the citation: https://guides.dataverse.org/en/6.0/api/native-api.html#get-citation It was added in PR #9592 and updated in PR #10121.
This means that passing the dataset version is required.
I'm somewhat confused by what "direct" means. I see it was added in a commit by @qqmyers in c0c852f . I hope I'm using it right. Some Javadoc would be welcome.
Suggestions on how to test this:
Create datasets, upload files, check the file citation JSON for drafts, published, and deaccessioned. Note that there are automated tests for all of these cases.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
No.
Is there a release notes update needed for this change?:
Included.
Additional documentation:
Included: https://dataverse-guide--10246.org.readthedocs.build/en/10246/api/native-api.html#get-file-citation-as-json