Merged
Conversation
github-actions
bot
added
GREI Re-arch
ChengShi-1
reviewed
Sep 2, 2025
Contributor
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
Great work! just small suggestions about checking persistent id as a parameter
ChengShi-1
previously approved these changes
Sep 3, 2025
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
Author
|
Waiting on IQSS/dataverse#11760 |
g-saracca
moved this from In Progress 💻
to Ready for Review ⏩
in IQSS Dataverse Project
Contributor
Author
|
@ChengShi-1 this is also ready for review now, related API PR was merged so I just solved merge conflicts and un-skip the tests 👍🏼 |
github-project-automation
bot
moved this from In Review 🔎
to Ready for QA ⏩
in IQSS Dataverse Project
Contributor
|
looks good to me - merging |
github-project-automation
bot
moved this from Ready for QA ⏩
to Merged 🚀
in IQSS Dataverse Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds 3 new use cases.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
This PR is ready but integration tests will fail until related dataverse PR is merged.
Suggestions on how to test this:
Code visual inspection and test passing.
Is there a release notes update needed for this change?:
No.
Additional documentation:
No