Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new use case to retrieve storage driver configuration information for datasets, supporting the Dataverse API endpoint GET /datasets/{identifier}/storageDriver.
- Adds
GetDatasetStorageDriveruse case andStorageDrivermodel interface - Implements repository method in
DatasetsRepositoryand interface inIDatasetsRepository - Includes comprehensive unit and integration tests for the new functionality
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/datasets/domain/models/StorageDriver.ts |
Defines the StorageDriver interface with properties for storage configuration |
src/datasets/domain/useCases/GetDatasetStorageDriver.ts |
Implements the use case to retrieve storage driver information for a dataset |
src/datasets/domain/repositories/IDatasetsRepository.ts |
Adds method signature for getDatasetStorageDriver to the repository interface |
src/datasets/infra/repositories/DatasetsRepository.ts |
Implements the getDatasetStorageDriver method to call the API endpoint |
src/datasets/index.ts |
Exports the new getDatasetStorageDriver use case |
test/unit/datasets/GetDatasetStorageDriver.test.ts |
Adds unit tests for the use case with success and error scenarios |
test/integration/datasets/DatasetsRepository.test.ts |
Adds integration test to verify the repository method works with the API |
docs/useCases.md |
Documents the new use case with usage examples and parameter descriptions |
CHANGELOG.md |
Records the addition of the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
ekraffmiller
approved these changes
Jan 7, 2026
Contributor
ekraffmiller
left a comment
There was a problem hiding this comment.
looks good, approved!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Create Get Dataset Storage Driver use case
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes or changelog update needed for this change?:
yes, changelog updated
Additional documentation: