feature to extend the get storage driver API#11716
Conversation
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@stevenwinship These are the JVM_ARGS we set for the dockerized environment. |
|
I'm glad to see that this hasn't been merged yet. We clearly need this API to also say whether direct upload is enabled on this storage volume; as in something like The SPA supports direct uploads only. In the current implementation, the hard-coded assumption is that any S3 volume has direct upload; this is true in the IQSS prod. environment, but is not universally the case. Case in point - the setup on demo. |
|
@qqmyers refresh my addled memory here; I couldn't find the issue that I opened about allowing external tools such as dv-uploader to remotely determine whether direct-upload is enabled but this sounds extremely useful. |
|
possibly #8374 . Maybe less important but probably worth sending whether directdownload is enabled too. I could also see |
Yep, crossed my mind too. And, possibly, the max file size limit as well? (which is also defined per storage volume)
If that was #8374, we can add it to |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
landreev
left a comment
There was a problem hiding this comment.
This appears to have fallen through the cracks; I for one assumed (again) that it was merged already, and I take responsibility for that.
Approving now...
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
continuous integrations been failing on this one |
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
|
tests now passing - looks good from my end - merging. |
…-dataset-storageDriver_api Fixes for #11716
What this PR does / why we need it: SPA needs more information in the Json response to get the storage driver info
Which issue(s) this PR closes:#11695
Special notes for your reviewer: backward incompatible Json response.
Suggestions on how to test this:
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: changelog updated