Add use cases for file tab data visualization#80
Merged
Conversation
… into 77-files-display-data-use-cases
…(pending tests and refactoring)
pdurbin
changed the title
MellyGray
reviewed
Aug 11, 2023
1 task
MellyGray
reviewed
Aug 17, 2023
Contributor
MellyGray
left a comment
MellyGray
left a comment
There was a problem hiding this comment.
✅ Tests passing
✅ Code looks good overall (Just a few comments, not critical things so I don't want to block this PR)
MellyGray
approved these changes
Aug 18, 2023
Contributor
MellyGray
left a comment
MellyGray
left a comment
There was a problem hiding this comment.
All threads solved! There is some refactoring going on in another PR to not block this one. Moving this to QA!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds the use case logic to support the frontend files tab display data.
The new use case logic needs the API changes implemented in IQSS/dataverse#9692 to work.
In particular, this PR adds the following new use cases to the package:
In addition, the dataset use cases have been refactored. In particular, the old getDatasetById and getDatasetByPersistentId use cases are merged into a single getDataset use case, which is inferring the type of id specified.
Which issue(s) this PR closes:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
New use cases for files: