Conversation
MellyGray
approved these changes
Aug 31, 2023
Contributor
MellyGray
left a comment
There was a problem hiding this comment.
LGTM 🎉 nothing to add, let's move it forward!
Contributor
|
@GPortas Do you know where currently this is used in UI. In addition to automated tests, just wanted to try it out in pre SPA ui. |
Contributor
Hi @kcondon ! You can try it out in this branch PR IQSS/dataverse-frontend#173 |
Contributor
|
Sorry, first day back testing SPA and have temporarily forgotten some basic steps, like checking which repo the pr is for. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds a new FileCriteria parameter to the getDatasetFiles use case, which applies different optional filters to the final API call.
Also includes a small refactor described in #80 (comment)
Adds latestRestricted property to File model (dataFile level).
Which issue(s) this PR closes:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Adds filters to getDatasetFiles use case