Skip to content

Add filters to getDatasetFiles use case#82

Merged
kcondon merged 5 commits intodevelopfrom
80-files-filters
Sep 11, 2023
Merged

Add filters to getDatasetFiles use case#82
kcondon merged 5 commits intodevelopfrom
80-files-filters

Conversation

@GPortas
Copy link
Contributor

@GPortas GPortas commented Aug 17, 2023

What this PR does / why we need it:

Adds a new FileCriteria parameter to the getDatasetFiles use case, which applies different optional filters to the final API call.

Also includes a small refactor described in #80 (comment)

Adds latestRestricted property to File model (dataFile level).

Which issue(s) this PR closes:

Suggestions on how to test this:

  • Visual inspection of the code
  • Check unit and integration tests execution in GitHub actions

Is there a release notes update needed for this change?:

Adds filters to getDatasetFiles use case

@GPortas GPortas changed the title Add filters tab data visualization Add filters to getDatasetFiles use case Aug 17, 2023
@GPortas GPortas marked this pull request as ready for review August 17, 2023 09:39
Base automatically changed from 77-files-display-data-use-cases to develop August 25, 2023 19:54
@GPortas GPortas added the Size: 10 A percentage of a sprint. 7 hours. label Aug 30, 2023
@MellyGray MellyGray self-assigned this Aug 30, 2023
Copy link
Contributor

@MellyGray MellyGray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 nothing to add, let's move it forward!

@kcondon
Copy link
Contributor

kcondon commented Sep 11, 2023

@GPortas Do you know where currently this is used in UI. In addition to automated tests, just wanted to try it out in pre SPA ui.

@MellyGray
Copy link
Contributor

@GPortas Do you know where currently this is used in UI. In addition to automated tests, just wanted to try it out in pre SPA ui.

Hi @kcondon ! You can try it out in this branch PR IQSS/dataverse-frontend#173

@kcondon
Copy link
Contributor

kcondon commented Sep 11, 2023

Sorry, first day back testing SPA and have temporarily forgotten some basic steps, like checking which repo the pr is for. :)

@kcondon kcondon self-assigned this Sep 11, 2023
@kcondon kcondon merged commit ddf1a7b into develop Sep 11, 2023
@kcondon kcondon deleted the 80-files-filters branch September 11, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Size: 10 A percentage of a sprint. 7 hours.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants