Add use case to retrieve file counts by type, access and category#88
Add use case to retrieve file counts by type, access and category#88
Conversation
MellyGray
left a comment
MellyGray
left a comment
There was a problem hiding this comment.
Looks good! I appreciate the included refactor 👏 I'm going to start integrating this into the frontend right away
I added a comment about a naming but it's a matter of preference so I'm not blocking this PR, if you agree with the comment and want to do the change just go ahead and ask for a new approval afterwards
| }); | ||
| } | ||
|
|
||
| protected buildApiEndpoint(resourceName: string, operation: string, resourceId: number | string = undefined) { |
There was a problem hiding this comment.
love the refactor using this method 👍
|
|
||
| public async getDatasetSummaryFieldNames(): Promise<string[]> { | ||
| return this.doGet('/datasets/summaryFieldNames') | ||
| return this.doGet(this.buildApiEndpoint(this.resourceName, 'summaryFieldNames')) |
There was a problem hiding this comment.
I think I like it better in FileRepository where the dataset resource name has this naming this.datasetsResourceName
return this.doGet(this.buildApiEndpoint(this.datasetsResourceName, 'summaryFieldNames'))
I think it helps visually seeing which resource is calling, specially because it seems like the resource called is not always the one in the repository name
|
@GPortas I think this PR wasn't published to the npm registry https://github.com/IQSS/dataverse-client-javascript/pkgs/npm/dataverse-client-javascript can you publish it? |
3 participants
What this PR does / why we need it:
Adds use case for getting file counts, as requested in #83.
In addition, it includes a small refactoring for the API endpoint building in the API repositories.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this:
Is there a release notes update needed for this change?:
Add GetDatasetFileCounts use case
Additional documentation:
None