Dataset Pg - Rogue form buttons at bottom of page (again) with guestbook

[mheppler]

This bug was last reported and fixed in #4838 (thanks GitHub new Related Issues feature!) which was released in 4.9.3, and it is back again. Noticed this on dataverse-internal running v. 4.15 build 302-beb88dc, while I was presenting (thanks @scolapasta) the dataset pg UI at the community mtg.

Could be related to the accessibility changes to the buttons in #5717 merged in 4.15, that included changes to the button for popup, as well as other style changes and render logic refactoring.

Sigh.

[mheppler]

And as if that wasn't bad enough, if you use the search box above the files tables, you get a second set of rogue buttons. (H/T @scolapasta)

[mheppler]

With guidance from the master of bug replication, @kcondon, was finally able to sort out the very tricky series of events required to replicate this bug...

1. create dataset with the 3 files (tabular, image, text)
2. PUBLISH
3. restrict image file
4. PUBLISH
5. select guestbook from terms tab
6. PUBLISH, see rogue "downloadPopup" buttons

Confirmed this bug on dataverse-internal and locally.

[mheppler]

Fixed this in the branch 5958-rogue-dataset-popup-btns with 08858f8.

It was once again a case of jsf:rendered being used on a plain HTML button tag, so I have reverted that back to a ui:fragment component.

        <ui:fragment rendered="#{DatasetPage.compareVersionsCount > 2}">
            <button type="button" class="btn btn-default" onclick="testCheckBoxes();">
                <span class="glyphicon glyphicon-transfer"/> #{bundle['file.dataFilesTab.versions.viewDiffBtn']}
            </button>
        </ui:fragment>

You can see from the render logic in that code snippet, why it was difficult replicate. You needed to have 2 or more versions of a dataset AND a guestbook with custom questions -- which uses the p:selectOneMenu component.

I still believe there is something inherently wrong with that p:selectOneMenu component. The specific example of it in question, in the Download popup of the dataset pg, keeps resulting as the layout breaking point, but I can not seem to find a reason why, or any references online to others reporting similar problems.

After talking to @scolapasta, fixed two other button elements on the dataset that have jsf:rendered as a result of the work I did in the accessibility issue #5717 in 4.15. Those have been reverted back to using plain HTML button tags wrapped in a ui:fragment component that houses the render logic.