-
Notifications
You must be signed in to change notification settings - Fork 535
Closed
Milestone
Description
In working through #8917, I noticed
- that a template with terms of access defined does not show the ToA in the template view mode - due to line 267,
- the collapse state for the TofA pane in template view isn't initially set correctly due to use of jsf:class instead of class,
- there is no display of template fileaccessrequest status in the template view - the existing html isn't rendered in the template view and, if it were, the logic inside appears to check the dataset setting and, due to issues like those described in fix npes on template page #8917, the template view would always default to fileaccessrequest not set due to a silent null.
- the check re: displaying the restricted file count appears unnecessary as the div enclosing it isn't shown unless you are on the dataset page and there are restricted files.
I didn't have time to look for further issues, so might suggest a bit of a spike to have someone check that template edit/view works as expected after #8917 and see if there are more before addressing the things above. I think most are straight forward to fix though the collapse state one may take some work as both the collapse state and the up/down chevron have to be synched and it wasn't clear to me if the design was to start with that panel open or closed.
What steps does it take to reproduce the issue? as described
- Which page(s) does it occurs on? Viewing templates.
Which version of Dataverse are you using?
develop before/after #8917
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels