9913 template preview - fix display of Terms of Access#9967
Merged
Conversation
qqmyers
approved these changes
Sep 28, 2023
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Haven't tested but I did walk through code to identify that the DatasetPage.restrictedFileCount > 0 was what was shutting this off in the template preview and this fix looks like it should work - easy to see in QA.
Contributor
Author
|
I'm going to pull this back because Gustavo asked me to take a look at related issues to see if they would be fixed by this or if they are low-hanging fruit to add to this, but thanks for the quick action @qqmyers |
also fix various render issues.
Contributor
Author
qqmyers
reviewed
Sep 29, 2023
Member
qqmyers
left a comment
qqmyers
left a comment
There was a problem hiding this comment.
Looks good - one question about the request access selected entry showing on the template page.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
qqmyers
approved these changes
Oct 2, 2023
|
📦 Pushed preview images as 🚢 See on GHCR. Use by referencing with full name as printed above, mind the registry name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows Terms of Access to display on template view/preview
Which issue(s) this PR closes:
Closes #9913 template preview should display terms of access, etc.
Closes #8918 Template View issues.
Closes #8781 Collapse not working for Restricted files TOA
Special notes for your reviewer:
Suggestions on how to test this:
Add terms of access and see that it is displayed with preview on the manage templates page
Does this PR introduce a user interface change? If mockups are available, please link/include them here: No
Is there a release notes update needed for this change?: no
Additional documentation: none