IQSS/10656-fix permission check for request access notifications/emails #10657
Merged
sekmiller merged 1 commit intoIQSS:developfrom Jun 27, 2024
Merged
Conversation
qqmyers
changed the title
scolapasta
approved these changes
Jun 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Per the issue, emails about file access requests are being sent to people with ManageDatasetPermission rather than the new ManageFilePermission. This PR is a one line fix for that.
Which issue(s) this PR closes:
Closes #10656
Special notes for your reviewer:
Suggestions on how to test this: Setup a dataset with restricted files and add people with filemanager permission, verify that they receive notifications/emails when file access is requested.
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: