Skip to content

QDR: PID bug fixes#10708

Merged
ofahimIQSS merged 13 commits intoIQSS:developfrom
QualitativeDataRepository:QDR-PIDBugFixes
Oct 28, 2024
Merged

QDR: PID bug fixes#10708
ofahimIQSS merged 13 commits intoIQSS:developfrom
QualitativeDataRepository:QDR-PIDBugFixes

Conversation

@qqmyers
Copy link
Member

@qqmyers qqmyers commented Jul 20, 2024

What this PR does / why we need it:
Multiple small bug fixes/updates related to the PID handling and MDC citation retrieval code:

  • avoid deprecated new URL call
  • use correct PID setting when calling MDC API for citations
  • make DOI comparisons case insensitive
  • also insensitive in managed/excluded lists
  • simplify parsing of DOIs in citations
  • avoid one empty entry in managed/excluded sets when there are no PIDs listed.
  • return correct type for DataCiteDOIProvider
  • add is-supplement-to relationship (was supplements only)

Which issue(s) this PR closes:

Closes #10635

Special notes for your reviewer:

Suggestions on how to test this: The main tests would be to confirm that MDC citation retrieval works and that using a shoulder in lower/mixed case works, or vice-versa, that typing DOIs with lower case when the shoulder is upper case works (.e.g. /dataset.xhtml?persistentId=doi:10.33564/fk2LCUIJZ and /dataset.xhtml?persistentId=doi:10.33564/FK2LCUIJZ both resolve to the dataset page).

Does this PR introduce a user interface change? If mockups are available, please link/include them here:

Is there a release notes update needed for this change?: included

Additional documentation:

@qqmyers qqmyers added Size: 3 A percentage of a sprint. 2.1 hours. GDCC: QDR of interest to QDR Consider For Next Release A simple change (eg bug fix) that would be good to prioritize since it has been seen in the wild labels Jul 21, 2024
@coveralls
Copy link

coveralls commented Sep 3, 2024

Coverage Status

coverage: 20.878% (+0.009%) from 20.869%
when pulling a7e0d87 on QualitativeDataRepository:QDR-PIDBugFixes
into a0cb73d on IQSS:develop.

@cmbz cmbz added the FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) label Sep 25, 2024
@stevenwinship stevenwinship self-assigned this Sep 27, 2024
@stevenwinship stevenwinship removed their assignment Sep 30, 2024
@cmbz cmbz added this to the 6.5 milestone Sep 30, 2024
@cmbz cmbz added the FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) label Oct 9, 2024
@pdurbin pdurbin added the Type: Bug a defect label Oct 9, 2024
@cmbz cmbz added the FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) label Oct 23, 2024
@ofahimIQSS ofahimIQSS self-assigned this Oct 28, 2024
@ofahimIQSS
Copy link
Contributor

Fix looks good - merging PR.
Testing of 10708.docx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Consider For Next Release A simple change (eg bug fix) that would be good to prioritize since it has been seen in the wild FY25 Sprint 7 FY25 Sprint 7 (2024-09-25 - 2024-10-09) FY25 Sprint 8 FY25 Sprint 8 (2024-10-09 - 2024-10-23) FY25 Sprint 9 FY25 Sprint 9 (2024-10-23 - 2024-11-06) GDCC: QDR of interest to QDR Size: 3 A percentage of a sprint. 2.1 hours. Type: Bug a defect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DataCite Citations

6 participants