Merged
Conversation
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/AbstractDOIProvider.java
Outdated
Show resolved
Hide resolved
stevenwinship
approved these changes
Sep 30, 2024
Contributor
|
Fix looks good - merging PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Multiple small bug fixes/updates related to the PID handling and MDC citation retrieval code:
Which issue(s) this PR closes:
Closes #10635
Special notes for your reviewer:
Suggestions on how to test this: The main tests would be to confirm that MDC citation retrieval works and that using a shoulder in lower/mixed case works, or vice-versa, that typing DOIs with lower case when the shoulder is upper case works (.e.g. /dataset.xhtml?persistentId=doi:10.33564/fk2LCUIJZ and /dataset.xhtml?persistentId=doi:10.33564/FK2LCUIJZ both resolve to the dataset page).
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?: included
Additional documentation: