Fix lookups of Harvested datasets with lower-case versions of persistent identifiers in the database#11003
Merged
landreev merged 7 commits intoIQSS:developfrom Nov 8, 2024
Conversation
Will use upper case form of DOI identifier to support case-insensitive retrieval
…iers, making the searches case-insensitive and making it possible to look up any lower case or mixed-case persistent ids already in the database. IQSS#11003
landreev
changed the title
stevenwinship
approved these changes
Nov 7, 2024
Contributor
|
@qqmyers @stevenwinship thank you for the extra effort with the index, etc. |
60 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: The recent changes to support lower case shoulders in #10708 accidentally broke retrieval of harvested datasets with lowercase DOIs (which is newly possible with DataCite as the Harvesting source). This fix stores harvested DOIs in their original case (useful if the harvesting source is not case-insensitive even though it should be) but changes to using case-insensitive DB queries so case-insensitive retrieval works.
Which issue(s) this PR closes:
Special notes for your reviewer:
Suggestions on how to test this: Verify that the dataset page works for DOIs when the db identifier for it is in lower/mixed case in the database. This only happens naturally when Harvesting from a source that provides a lower/mixed case DOI. To test, editing the db entry for a normal/internal DOI would work. Regression testing - datasets with normal DOIs, PermaLinks, Handles as the identifier/alternative identifier should continue to work and be case insensitive (i.e. one can change the dataset page URL to use lowercase letters and it should still work.)
Does this PR introduce a user interface change? If mockups are available, please link/include them here:
Is there a release notes update needed for this change?:
Additional documentation: