Skip to content

2170 confirm email#3299

Merged
kcondon merged 48 commits intodevelopfrom
2170-confirm-email
Sep 22, 2016
Merged

2170 confirm email#3299
kcondon merged 48 commits intodevelopfrom
2170-confirm-email

Conversation

@bsilverstein95
Copy link
Contributor

@bsilverstein95 bsilverstein95 commented Aug 19, 2016 •
edited by kcondon
Loading

RFI Checklist

1. Related Issues

2. Pull Request Checklist

  • Functionality completed as described in FRD (No FRD)
  • Dependencies, risks, assumptions in FRD addressed (No FRD)
  • Unit tests completed (+ restassured tests)
  • Deployment requirements identified (e.g., SQL scripts, indexing) (scripts/database/upgrades/confirmemail.sql)
  • Documentation completed (New docs in installation guide)
  • All code checkins completed

3. Review Checklist

After the pull request has been submitted, fill out this section.

  • Code review completed or waived (done by @raprasad)
  • Testing requirements completed
  • Usability testing completed or waived
  • Support testing completed or waived
  • Merged with develop branch and resolved conflicts

bsilverstein95 and others added 30 commits July 25, 2016 14:05
@bsilverstein95
Progress toward confirm email feature #2170
8885e71
@pdurbin
Confirm Email: don't expose token to user on create #2170
ab55794
@bsilverstein95
Successful confirmation in int. test via xhtml page/logic reformat #2170
dd768d9
@pdurbin
Confirm email: delete old, unused code #2170
8b79ec1
@pdurbin
make minutesUntilConfirmEmailTokenExpires configurable #2170
3fc6e8f
@pdurbin
Confirm Email: create token in central location #2170
814d58b
@pdurbin
Confirm Email: show "Not Verified" #2170
540cb95
@pdurbin
set "confirmed" timestamp to null on email change, create token #2170
4bb6f7b
@bsilverstein95
Added logic to remove used token upon confirmation reflected in IT #2170
a0dc4f9
@pdurbin
Confirm Email: expect a 404 when no token found #2170
733a180
@pdurbin
Confirm Email: update welcome email to include link #2170
733b65e
@pdurbin
Confirm Email: send link on password change #2170
4710fd7
@pdurbin
Confirm Email: add test to exercise delete user bug #2170
064d0c2
@bsilverstein95
Refactored sendLinkOnEmailChange method to employ BundleUtil #2170
a05f0dd
@pdurbin
Confirm Email: add/remove "Email Not Verfied" immediately #2170
42c6fa3
@bsilverstein95
Added testConfirmUserWithTokenCanBeDeleted() #2170
cd0d596
@pdurbin
Confirm Email: error and success handling done? #2170
60f797b
@bsilverstein95
Added findSingleConfirmEmailDataByUser() and fixed deletion bug #2170
689f509 
Added friendlyExpirationTime() and dynamic time measurements for email
@pdurbin
increase code coverage for ConfirmEmailUtil from 90% to 100% #2170
05a43dd
@pdurbin
Confirm Email: add "Verify Email" button #2170
5c8eb2c
@pdurbin
Confirm Email: clean up tests and delete user #2170
40ea2ee
@pdurbin
Confirm Email: prevent multiple tokens for a user #2170
03e4b6a
@pdurbin
Confirm Email: refactor, delete dead code, more API tests #2170
36c7650
@bsilverstein95
Fixed time syntax for sent email & Verify Email button logic #2170
ff0607f
@bsilverstein95
Merge branch '2170-confirm-email' of github.com:IQSS/dataverse into 2…
0fbbd7f 
…170-confirm-email
@pdurbin
Confirm Email: Shib users don't have to confirm #2170
4f1f928
@bsilverstein95
Updated ConfirmEmailUtilTest.java with more assertions #2170
867ed48
@pdurbin
Confirm email: delete method we don't need anymore #2170
614c157
@pdurbin
Confirm Email: added todos, some cleanup #2170
166aaf0
@pdurbin
Confirm Email: clean up pull request and add todos #2170
43251f6
@pdurbin pdurbin assigned raprasad and unassigned raprasad Aug 19, 2016
@pdurbin
Copy link
Member

pdurbin commented Aug 19, 2016

@raprasad indicated that he checked the code review box. Over to QA.

@pdurbin
Copy link
Member

pdurbin commented Sep 1, 2016

In a sprint planning meeting today we decided we're going to try to get this pull request in 4.5.1 so I'm giving it that milestone.

@pdurbin pdurbin added this to the 4.5.1 - IP Groups fixes milestone Sep 1, 2016
@coveralls
Copy link

coveralls commented Sep 1, 2016

Coverage Status

Coverage increased (+1.2%) to 7.932% when pulling b13f9be on 2170-confirm-email into a1f66a5 on develop.

@coveralls
Copy link

coveralls commented Sep 2, 2016

Coverage Status

Coverage increased (+0.002%) to 7.932% when pulling 209db67 on 2170-confirm-email into dc58ae1 on develop.

@coveralls
Copy link

coveralls commented Sep 2, 2016

Coverage Status

Coverage increased (+0.002%) to 7.932% when pulling 139c48f on 2170-confirm-email into dc58ae1 on develop.

@coveralls
Copy link

coveralls commented Sep 2, 2016

Coverage Status

Coverage increased (+0.002%) to 7.933% when pulling 3fd9263 on 2170-confirm-email into dc58ae1 on develop.

@kcondon kcondon removed the Status: QA label Sep 9, 2016
@coveralls
Copy link

coveralls commented Sep 22, 2016

Coverage Status

Coverage increased (+0.002%) to 7.933% when pulling 6e9833f on 2170-confirm-email into 2df5aea on develop.

@coveralls
Copy link

coveralls commented Sep 22, 2016

Coverage Status

Coverage increased (+0.002%) to 7.933% when pulling 6e9833f on 2170-confirm-email into 2df5aea on develop.

@kcondon kcondon merged commit bcc57e4 into develop Sep 22, 2016
@pdurbin pdurbin mentioned this pull request Sep 23, 2016
Closed
@pdurbin pdurbin deleted the 2170-confirm-email branch September 23, 2016 14:24
@pdurbin pdurbin mentioned this pull request Jun 1, 2017
Closed
This was referenced Apr 6, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.5.1 - IP Groups fixes

Development

Successfully merging this pull request may close these issues.

7 participants

@bsilverstein95 @coveralls @pdurbin @raprasad @kcondon @djbrooke @mheppler