Merged
Conversation
…pdated documentation.rst and geospatial.rst to include table of contents preface
…dev-guide #3431 Resolved ToC Conflicts: doc/sphinx-guides/source/developers/documentation.rst doc/sphinx-guides/source/developers/geospatial.rst doc/sphinx-guides/source/developers/testing.rst
Phil and I are confused about whether our merge conflict worked! Testing out this fix.
Changed filename and title of page and added a section called "Using Git" with info on how to make commits and resolve merge conflicts.
Fixed a couple typos in the Version Control page. Lookin' good!
Made minor typo/style fixes to testing.rst. Also looked over dev-environment.rst and it's all good.
Fixed a header typo I'd missed before.
Merged
Conflicts: doc/sphinx-guides/source/developers/dev-environment.rst
Changed formatting to fix issues with issue syntax and Waffle.
Contributor
|
In terms of suggested netbeans settings, add that says roughly, go to options -> editor -> hints and check the following (at least): |
zhul-pku
reviewed
Jun 20, 2017
zhul-pku
left a comment
zhul-pku
left a comment
There was a problem hiding this comment.
For vagrant and VirtualBox, if there is an error like "vitualbox has halted", it could possibly be fixed after something changes are made to the vagrant script and some changes are made to the BIOS settings of windows laptop.
| Avoid Hard-Coding Strings | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
||
| Special strings should be defined as public constants. For example, ``DatasetFieldConstant.java`` contains has a field for "title" and it's used in many places in the code (try "Find Usages" in Netbeans). This is better than writing the string "title" in all those places. |
Contributor
There was a problem hiding this comment.
Because (among other reasons), it makes translation easier.
|
|
||
| - "Raw Types" under "Standard Javac Warnings" | ||
|
|
||
| If you know of a way to easily share Netbeans configuration across a team, please get in touch. |
Contributor
There was a problem hiding this comment.
You can export/import.
Small fixes to Coding Style page.
Also link to list of contributors.
This was referenced Jun 20, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Contributors
Welcome! New contributors should at least glance at CONTRIBUTING.md, especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!
Related Issues
Pull Request Checklist