Merged
Conversation
poikilotherm
force-pushed
the
4690-custom-s3-endpoint
branch
3 times, most recently
from
44bd2e8 to
97eaadc
Compare
This was referenced Sep 20, 2018
poikilotherm
force-pushed
the
4690-custom-s3-endpoint
branch
2 times, most recently
from
f3a89c5 to
cbddc5b
Compare
poikilotherm
changed the title
poikilotherm
force-pushed
the
4690-custom-s3-endpoint
branch
from
cbddc5b to
ca0aa99
Compare
Closed
matthew-a-dunlap
suggested changes
Sep 24, 2018
Contributor
matthew-a-dunlap
left a comment
matthew-a-dunlap
left a comment
There was a problem hiding this comment.
Overall this looks great! Standard aws functions work for me. I have a few thoughts and some other folks want to look over the docs in more depth.
src/main/java/edu/harvard/iq/dataverse/dataaccess/S3AccessIO.java
Outdated
Show resolved
Hide resolved
poikilotherm
force-pushed
the
4690-custom-s3-endpoint
branch
from
ca0aa99 to
cea0b80
Compare
poikilotherm
commented
Sep 27, 2018
poikilotherm
force-pushed
the
4690-custom-s3-endpoint
branch
from
999de28 to
42d9469
Compare
Contributor
Author
pdurbin
reviewed
Sep 28, 2018
pdurbin
reviewed
Sep 28, 2018
Member
|
@poikilotherm can you please resolve the merge conflicts? |
poikilotherm
force-pushed
the
4690-custom-s3-endpoint
branch
3 times, most recently
from
08bd6cb to
060fbc8
Compare
Contributor
Author
Contributor
|
No problem, @poikilotherm. I just took a look at your recent edits to the docs and they look good to me. Thanks for all your work on this. |
…aven property 'compilerArgument'. The property name was passed as argument string to the compiler, which of course failed. Adding an empty default fixes this.
…isible and adding a constructor to inject a mocked AWS S3 Client
…upiter support via Maven.
…, as the class could use some refactoring and more documentation.
…s using a custom EndpointConfiguration. Will default to previous standard configuration.
…use custom S3 endpoints.
…d with many custom S3 services like Minio.
Made some edits to structure and content to match the rest of the page.
Changed first paragraph, fixed list formatting.
…purposes in the docs.
poikilotherm
force-pushed
the
4690-custom-s3-endpoint
branch
from
eb2ae87 to
b7b5d8a
Compare
Contributor
Author
|
@kcondon: I just pushed a freshly rebased feature branch. Thx for your proper job on the QA part! 😄 |
poikilotherm
added a commit
to poikilotherm/dataverse
that referenced
this pull request
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review and merge, thank you! 😄
Will solve #4690 by ...
Related Issues
Pull Request Checklist